commit bd77c59acc58e797756b0fcc6739319587e95d85 Author: Bob Wilson Date: Fri Aug 2 22:25:34 2013 +0000 Only use the Darwin linker's -export_dynamic option with supported versions. Related to . git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@187680 91177308-0d34-0410-b5e6-96231b3b80d8 diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp index 33e2803..dfaffaa 100644 --- a/tools/clang/lib/Driver/Tools.cpp +++ b/tools/clang/lib/Driver/Tools.cpp @@ -4517,6 +4517,9 @@ void darwin::Link::AddLinkArgs(Compilation &C, CmdArgs.push_back("-demangle"); } + if (Args.hasArg(options::OPT_rdynamic) && Version[0] >= 137) + CmdArgs.push_back("-export_dynamic"); + // If we are using LTO, then automatically create a temporary file path for // the linker to use, so that it's lifetime will extend past a possible // dsymutil step. @@ -4724,9 +4727,6 @@ void darwin::Link::ConstructJob(Compilation &C, const JobAction &JA, if (Args.hasArg(options::OPT_ObjC) || Args.hasArg(options::OPT_ObjCXX)) CmdArgs.push_back("-ObjC"); - if (Args.hasArg(options::OPT_rdynamic)) - CmdArgs.push_back("-export_dynamic"); - CmdArgs.push_back("-o"); CmdArgs.push_back(Output.getFilename()); diff --git a/test/Driver/darwin-ld.c b/test/Driver/darwin-ld.c index cd511e0..d6c5170 100644 --- a/tools/clang/test/Driver/darwin-ld.c +++ b/tools/clang/test/Driver/darwin-ld.c @@ -130,3 +130,17 @@ // RUN: FileCheck -check-prefix=LINK_PG %s < %t.log // LINK_PG: -lgcrt1.o // LINK_PG: -no_new_main + +// RUN: %clang -target x86_64-apple-darwin12 -rdynamic -### %t.o \ +// RUN: -mlinker-version=100 2> %t.log +// RUN: FileCheck -check-prefix=LINK_NO_EXPORT_DYNAMIC %s < %t.log +// LINK_NO_EXPORT_DYNAMIC: {{ld(.exe)?"}} +// LINK_NO_EXPORT_DYNAMIC-NOT: "-export_dynamic" + +// RUN: %clang -target x86_64-apple-darwin12 -rdynamic -### %t.o \ +// RUN: -mlinker-version=137 2> %t.log +// RUN: FileCheck -check-prefix=LINK_EXPORT_DYNAMIC %s < %t.log +// LINK_EXPORT_DYNAMIC: {{ld(.exe)?"}} +// LINK_EXPORT_DYNAMIC: "-export_dynamic" + +