commit 102ac0e7765796f49ccd271dd9de97885bc3c605 Author: Matthias Clasen Date: Mon May 25 23:29:41 2015 -0400 2.45.2 NEWS | 32 ++++++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 33 insertions(+), 1 deletion(-) commit 126c685f4aa627a8190e09adfc8ab0733c14a6ea Author: Matthias Clasen Date: Mon May 25 13:26:48 2015 -0400 GOptionContext: Improve help in simple cases Only add [OPTION...] to the usage line if the context has options. And shorten "Application Options" to just "Options" if we don't have to differentiate from other kinds of options. glib/goption.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) commit 525bbbd6bd7c9abb45c4ddfcfb8dcf45bbbd5726 Author: Emmanuele Bassi Date: Mon May 25 14:04:06 2015 +0100 Do not use a string literal when a format string is expected Otherwise we'll get compiler errors. Based on a patch by: Vincent Le Garrec https://bugzilla.gnome.org/show_bug.cgi?id=696749 gio/gregistrysettingsbackend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5e7e058a9c26fa735386cf45b41ad91cc7768137 Author: Emmanuele Bassi Date: Mon Apr 20 14:11:12 2015 +0100 docs: Add an example of G_DEFINE_BOXED_TYPE Mention that the GType of the boxed type is stored inside the g_define_type_id variable. See bug: https://bugzilla.gnome.org/show_bug.cgi?id=723394 gobject/gtype.h | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit 7313195ae776dad441b18fb948149dfdd6ae76cc Author: Akom Chotiphantawanon Date: Sun May 24 17:42:33 2015 +0700 Updated Thai translation po/th.po | 1203 ++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 628 insertions(+), 575 deletions(-) commit 13a9e8b7a649fb8739f47e88fc2ab4218b9aed7a Author: Dušan Kazik Date: Sat May 23 20:36:38 2015 +0000 Updated Slovak translation po/sk.po | 431 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 223 insertions(+), 208 deletions(-) commit 3bd703e9c4a4de0ea3faf2073ffaffcb182c5b5d Author: David Shea Date: Wed Apr 8 13:14:22 2015 -0400 Add introspection annotations to GListStore GListStore requires that item-type be derived from GObject, so specify that the type of the item parameters is GObject so the functions can be used via gobject-introspection. Add a scope parameter for the callback used during insert_sorted. gio/gliststore.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit 074fe89f226d4c0f3c6bdd48b6b03c8051fbaf75 Author: Matthias Clasen Date: Fri May 15 22:53:41 2015 -0400 glib-compile-schemas: Improve an error message Mention the expected type when failing to parse a GVariant. gio/glib-compile-schemas.c | 7 +++++++ 1 file changed, 7 insertions(+) commit aecac6e1cb80b3b5e64459f5a8536ad93d021c1b Author: Matthias Clasen Date: Fri May 15 22:41:29 2015 -0400 glib-compile-schemas: Show error positions GMarkup provides this information, pass it on. gio/glib-compile-schemas.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit d853ceddb5bd07e0835ef7b7953404f5c866832d Author: Jordi Mas Date: Fri May 15 22:14:44 2015 +0200 Fixes to Catalan translation po/ca.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 4c1f716ef6d8d9bf73e60175ebad52b2c1d13b6b Author: Alexandre Franke Date: Fri May 15 08:46:51 2015 +0000 Updated French translation po/fr.po | 443 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 228 insertions(+), 215 deletions(-) commit ace7846322634159271c5c75ccadfa3cade78620 Author: Simon McVittie Date: Tue Apr 28 10:10:58 2015 +0100 regex test: do not assert that system PCRE still has an 8.31 bug This was fixed in 8.32, so if we have that version, assert that it is fixed; if we don't (e.g. the current internal pcre), still don't assert that it *isn't* fixed. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=733325 Reviewed-by: Christian Persch Signed-off-by: Simon McVittie glib/tests/regex.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit fe1a2dc1965b564727480c8a99740252ea81274b Author: Iain Lane Date: Mon Mar 31 11:06:05 2014 +0100 gdbus tests: wait up to 60s for gdbus-testserver to take its bus name Previously, we waited up to 0.5s, but that can fail on slow architectures like ARM; now we wait up to 60s in 0.1s increments. Patch originally by Simon McVittie , modified by Iain Lane to be called earlier, to catch all testcases in a particular test. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=724113 Reviewed-by: Simon McVittie Acked-by: Matthias Clasen gio/tests/gdbus-connection-loss.c | 3 +-- gio/tests/gdbus-tests.c | 52 +++++++++++++++++++++++++++++++++++++++ gio/tests/gdbus-tests.h | 2 ++ gio/tests/gdbus-threading.c | 8 +----- 4 files changed, 56 insertions(+), 9 deletions(-) commit 3beb67f9f3b1db6ee133973edfd89df89d7bdde5 Author: Simon McVittie Date: Tue Feb 11 14:23:15 2014 +0000 gdbus-connection: wait up to 10s to actually send a message We previously waited 0.25s, which should be enough even on slow machines, but you never know; but we also now wait in 0.1s increments, so this test should actually be faster now. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=724113 Acked-by: Matthias Clasen gio/tests/gdbus-connection.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) commit f1c2e703454cb876a7df9c081c456a3df97b906e Author: Garrett Regier Date: Wed May 13 23:12:49 2015 -0700 Connect to the detailed notify signal in GBinding This avoids the notify handler being called for each and every emitted notify. https://bugzilla.gnome.org/show_bug.cgi?id=749353 gobject/gbinding.c | 44 ++++++++++++++++++++++++++------------------ 1 file changed, 26 insertions(+), 18 deletions(-) commit b07ba8ed3b3c6b2b0402946283e896ad66b0a573 Author: Garrett Regier Date: Wed May 13 22:15:27 2015 -0700 Fix g_binding_unbind() when the source and target are the same It tried to remove a weak ref, but it is only taken if the source and target object are different. https://bugzilla.gnome.org/show_bug.cgi?id=749352 gobject/gbinding.c | 9 +++++++-- gobject/tests/binding.c | 13 +++++++++++++ 2 files changed, 20 insertions(+), 2 deletions(-) commit 31496767c7caed25c134e58b0f41b1e696f671fe Author: Philip Withnall Date: Thu May 14 08:31:22 2015 +0100 gresource: Document generated C file function naming Mention the relationship to the --c-name argument, plus the need to call some_prefix_get_resource() to get the GResource object. gio/gresource.c | 6 ++++++ 1 file changed, 6 insertions(+) commit a8c157f92be6915549e1ec06e611e72da935385b Author: Philip Withnall Date: Thu May 14 08:15:46 2015 +0100 gresource: Minor capitalisation fixes in documentation gio/gresource.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) commit 6ac2e8c79a012e2d43292efdbd3250de31abff47 Author: Philip Withnall Date: Wed May 13 15:22:57 2015 +0100 gmessages: Tweak docs for G_LOG_DOMAIN to use AM_CPPFLAGS Instead of INCLUDES, which is deprecated in automake. Using AM_CPPFLAGS also gives the hint that the -D argument should be a CPPFLAGS variable, rather than CFLAGS. glib/gmessages.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 29d380cc5bbd97ee5b0c95b5499d6dd17523b71b Author: Garrett Regier Date: Tue Apr 14 20:44:38 2015 -0700 gtype: Bump allowed number of children Restricting the number of children to be less than 4095 can be an issue when generating types. This is also an issue for the Lua bindings as each Lua state will create a new GType each time the Lua code is executed. https://bugzilla.gnome.org/show_bug.cgi?id=747882 gobject/gtype.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 45dae4b5063f9af7de8211ced95dd73cc770a86e Author: Simon McVittie Date: Mon May 11 17:03:00 2015 +0100 tests: replace most g_print() with g_printerr() I searched all files that mention g_test_run, and replaced most g_print() calls. This avoids interfering with TAP. Exceptions: * gio/tests/network-monitor: a manual mode that is run by "./network-monitor --watch" is unaffected * glib/gtester.c: not a test * glib/gtestutils.c: not a test * glib/tests/logging.c: specifically exercising g_print() * glib/tests/markup-parse.c: a manual mode that is run by "./markup-parse --cdata-as-text" is unaffected * glib/tests/testing.c: specifically exercising capture of stdout in subprocesses * glib/tests/utils.c: captures a subprocess's stdout * glib/tests/testglib.c: exercises an assertion failure in g_print() Bug: https://bugzilla.gnome.org/show_bug.cgi?id=725981 Reviewed-by: Colin Walters Signed-off-by: Simon McVittie gio/tests/defaultvalue.c | 2 +- gio/tests/g-file.c | 4 +- gio/tests/gdbus-connection.c | 2 +- gio/tests/gdbus-export.c | 10 +-- gio/tests/gdbus-peer.c | 4 +- gio/tests/gdbus-proxy-threads.c | 4 +- gio/tests/gdbus-test-codegen.c | 2 +- gio/tests/gdbus-threading.c | 12 +-- gio/tests/live-g-file.c | 12 +-- glib/tests/1bit-mutex.c | 2 +- glib/tests/base64.c | 4 +- glib/tests/bookmarkfile.c | 26 +++--- glib/tests/cond.c | 16 ++-- glib/tests/fileutils.c | 6 +- glib/tests/gdatetime.c | 6 +- glib/tests/mutex.c | 2 +- glib/tests/private.c | 6 +- glib/tests/queue.c | 2 +- glib/tests/rec-mutex.c | 4 +- glib/tests/rwlock.c | 2 +- glib/tests/sequence.c | 8 +- glib/tests/shell.c | 2 +- glib/tests/utils.c | 2 +- gobject/tests/binding.c | 4 +- gobject/tests/dynamictests.c | 8 +- gobject/tests/private.c | 8 +- gobject/tests/threadtests.c | 8 +- tests/asyncqueue-test.c | 2 +- tests/testglib.c | 182 ++++++++++++++++++++-------------------- 29 files changed, 176 insertions(+), 176 deletions(-) commit 064183a633b7fcfd9b7c1b5a2917fb6f0e9128d3 Author: Simon McVittie Date: Mon May 11 16:50:00 2015 +0100 GFileMonitor test: use g_test_skip() instead of g_print() This stops it from interfering with structured stdout such as TAP. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=725981 Reviewed-by: Colin Walters Signed-off-by: Simon McVittie gio/tests/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0a9d91ab7b3b11df74a46d2068316a7c198e8558 Author: Simon McVittie Date: Mon May 11 16:38:57 2015 +0100 testglib: my_hash_callback_remove_test: actually fail the test The test is to remove all the odd values with my_hash_callback_remove(), then iterate over all values and verify that they are even. However, failing this check would just print "bad!" instead of failing the test. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=725981 Reviewed-by: Colin Walters Signed-off-by: Simon McVittie tests/testglib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4865538ce3d93dda802d25cbf93743e842507c5f Author: Simon McVittie Date: Mon May 11 16:34:35 2015 +0100 GTestDBus: use g_printerr() for status message This avoids any possibility of interfering with test syntax (such as TAP) on stdout. TAP specifically does not parse stderr. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=725981 Reviewed-by: Colin Walters Signed-off-by: Simon McVittie gio/gtestdbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 472dee39097881502bb593eb2effe37b3b6064a2 Author: Simon McVittie Date: Fri May 8 16:38:33 2015 +0100 gdatetime test: don't assume that time stands still If we call time(NULL), then do something (however trivial), then call g_date_time_new_now_utc(), they do not necessarily share a seconds value. Let's say the gmtime call takes 2ms. time(NULL) could return xx:xx:23 when the time is actually xx:xx:23.999999, resulting in the g_date_time_new_now_utc() happening at xx:xx:24.000001. This is unlikely, but did happen to me in a parallel build: GLib:ERROR:.../glib/tests/gdatetime.c:674:test_GDateTime_now_utc: assertion failed (tm.tm_sec == g_date_time_get_second (dt)): (23 == 24) A similar argument applies to the rollover from xx:23:59.999999 to xx:24:00, so comparing seconds with a 1s "fuzz" or a >= comparison is not sufficient; and so on into higher-order fields. I haven't seen the other tests that use _now() fail in the same way, but they could. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=749080 Reviewed-by: Philip Withnall Signed-off-by: Simon McVittie glib/tests/gdatetime.c | 79 +++++++++++++++++++++++++++++++++++++------------- 1 file changed, 59 insertions(+), 20 deletions(-) commit e18e7956bfc8a65ecec18b1837d5b7835312c40a Author: Evan Nemerson Date: Sat May 9 23:45:03 2015 -0700 gnetworkaddress: add return type annotation to parse methods https://bugzilla.gnome.org/show_bug.cgi?id=749180 gio/gnetworkaddress.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit bced30cfbb9d98fdaf71225bae3330e95ea548fa Author: Simon McVittie Date: Thu May 7 17:36:01 2015 +0100 GDBus tests: change progress noise from "if not quiet" to "if verbose" It seems that even after Bug #711796, these can still interfere with TAP testing: PASS: gdbus-proxy-threads 1 /gdbus/proxy/vs-threads tap-driver.sh: internal error getting exit status tap-driver.sh: fatal: I/O or internal error Let's shut them up unless --verbose is used (which would be appropriate when running them interactively). Similar symptoms have been seen in Debian: https://buildd.debian.org/status/fetch.php?pkg=glib2.0&arch=mipsel&ver=2.39.91-1&stamp=1394394568 and in Guix: https://lists.gnu.org/archive/html/bug-guix/2014-12/msg00002.html Bug: https://bugzilla.gnome.org/show_bug.cgi?id=725981 Reviewed-by: Philip Withnall Signed-off-by: Simon McVittie gio/tests/gdbus-proxy-threads.c | 4 ++-- gio/tests/gdbus-threading.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) commit 6f859fe21a1955ab60ba4aa7e22841c7dbffdea3 Author: Simon McVittie Date: Thu May 7 16:45:48 2015 +0100 gdbus-peer test: let GDBusServer start before notifying main thread When running the nonce-tcp and tcp-anonymous tests in one run of gdbus-peer, or running one of them twice via command-line options "-p /gdbus/tcp-anonymous -p /gdbus/tcp-anonymous", the one run second would sometimes fail to connect with ECONNRESET. Adding more debug messages revealed that in the successful case, g_main_loop_run() was executed in the server thread first: # tcp-anonymous: server thread: listening on tcp:host=localhost,port=53517 # tcp-anonymous: server thread: starting server... # tcp-anonymous: server thread: creating main loop... # tcp-anonymous: server thread: running main loop... # tcp-anonymous: main thread: trying tcp:host=localhost,port=53517... # tcp-anonymous: main thread: waiting for server thread... but in the failing case, the main thread attempted to connect before the call to g_main_loop_run() in the server thread: # tcp-anonymous: server thread: listening on tcp:host=localhost,port=40659 # tcp-anonymous: server thread: starting server... # tcp-anonymous: server thread: creating main loop... # tcp-anonymous: main thread: trying tcp:host=localhost,port=40659... # tcp-anonymous: server thread: running main loop... (The log message "creating main loop" was immediately before create_service_loop(), and "running main loop" was immediately before g_main_loop_run().) To ensure that the GDBusServer has a chance to start accepting connections before the main thread tries to connect to it, do not tell the main thread about the service_loop immediately, but instead defer it to an idle. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=749079 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall gio/tests/gdbus-peer.c | 41 ++++++++++++++++++++++++++++------------- 1 file changed, 28 insertions(+), 13 deletions(-) commit 474877d916439e20769a4aad4bccdedff2ad04ac Author: Piotr Drąg Date: Sun May 10 20:09:48 2015 +0200 Fix a minor typo in a comment glib/gdatetime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d92a67afcb4349bd3e9f6d02b0fd1acf4526d5be Author: Simon McVittie Date: Wed Apr 29 12:28:27 2015 +0100 gtestutils: better diagnostics if a captured subprocess fails It's unhelpful to get an error saying that stderr didn't match a desired pattern, or matched an undesired pattern, without also telling you what *was* on stderr. Similarly, if a test subprocess exits 1, there's probably something useful on its stderr that could have told you why. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=748534 Signed-off-by: Simon McVittie Reviewed-by: Dan Winship glib/gtestutils.c | 43 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 39 insertions(+), 4 deletions(-) commit f42d2c1b54541cf8d4e399f5c6d27d3ac40fc1a9 Author: Simon McVittie Date: Tue Apr 21 20:46:47 2015 +0100 gdbus-serialization: use check_serialization() instead of dbus-daemon This test originally did not connect to the bus, which meant it was omitted from commits like 415a8d81 that made sure none of GLib tests rely on the presence of an existing session bus. (In particular, Debian autobuilders don't have a session bus.) When test_double_array() was added, environments like the Debian autobuilders didn't catch the fact that this test relied on having a session bus, because it is often skipped in minimal environments due to its libdbus-1 dependency. We don't actually need to connect to a dbus-daemon here: it's enough to convert the message from GVariant to D-Bus serialization, and back into an in-memory representation through libdbus. That's what check_serialization() does, and I've verified that when I re-introduce bug #732754 by reverting commits 627b49b and 2268628 locally, this test still fails. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=744895 Signed-off-by: Simon McVittie Reviewed-by: Colin Walters gio/tests/gdbus-serialization.c | 26 ++++++++------------------ 1 file changed, 8 insertions(+), 18 deletions(-) commit 23a5352cd8a1f247ac831ebada9dbc9f5d24476f Author: Philip Withnall Date: Sun May 3 12:17:10 2015 +0100 glocalfilemonitor: Emit notification on rate limit change The changed variable was previously uninitialised in the path where the rate limit was actually changed. This could result in the GObject::notify signal not getting emitted. Spotted by Coverity. CID: #1296516 https://bugzilla.gnome.org/show_bug.cgi?id=748834 gio/glocalfilemonitor.c | 2 ++ 1 file changed, 2 insertions(+) commit 517ce45f8e21b2f7524fd429ee90ab1fbca9a30a Author: Ting-Wei Lan Date: Wed Apr 29 15:17:00 2015 +0800 gsocketlistener: Don't double unref address https://bugzilla.gnome.org/show_bug.cgi?id=748614 gio/gsocketlistener.c | 2 -- 1 file changed, 2 deletions(-) commit 34e946838d055cff810e32f6dba4331c49ea28c4 Author: Ting-Wei Lan Date: Wed Apr 29 14:55:00 2015 +0800 tests: Use de_DE.UTF-8 instead of de_DE de_DE.UTF-8 is supported by more operating systems, including FreeBSD, NetBSD and OpenBSD. https://bugzilla.gnome.org/show_bug.cgi?id=748612 glib/tests/option-context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)