commit e8a0e8f1b0ebaaee8f89e7002e11b99ef7cce2b3 Author: Matthias Clasen Date: Mon Jul 20 07:52:36 2015 -0400 3.17.5 NEWS | 11 +++++++++++ configure.ac | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) commit dee75bce2dc1cede3d4da79507cb20e6e08a7fdc Author: Matthias Clasen Date: Mon Jul 20 23:54:39 2015 -0400 Fix distcheck Makefile.decl does not work well with scripts that stay in srcdir, so generate test-simplify from test-simplify.in, just os that it ends up in builddir. testsuite/tools/Makefile.am | 6 +++++- testsuite/tools/test-simplify | 27 --------------------------- testsuite/tools/test-simplify.in | 27 +++++++++++++++++++++++++++ 3 files changed, 32 insertions(+), 28 deletions(-) commit 8102425f039536afa7c850fb239688a01e397380 Author: Matthias Clasen Date: Mon Jul 20 21:19:58 2015 -0400 places view: Disconnect from volume monitor Just unreffing the volume monitor object won't stop it from emitting signals that we are connected to. Disconnect from the signals in finalize. gtk/gtkplacesview.c | 4 ++++ 1 file changed, 4 insertions(+) commit 99d4ec267685f9aab0bdd172a6c3c7990db31524 Author: Benjamin Otte Date: Tue Jul 21 02:27:45 2015 +0200 reftests: Fix underlines in link-coloring reftest Underlines now need to be manually specified in CSS since GTK got text-decoration support. testsuite/reftests/link-coloring.css | 4 ++++ 1 file changed, 4 insertions(+) commit ceab99ff2ffcfd3f3e9644026ea9d4692cfbd11c Author: Benjamin Otte Date: Mon Jul 20 04:20:50 2015 +0200 treeview: Don't underallocate editing widgets that are too big gtk/gtktreeview.c | 38 +++++++++++++++++++++++++------------- 1 file changed, 25 insertions(+), 13 deletions(-) commit 3402363684de5577b267c743029b2f4a8ef6a9da Author: Benjamin Otte Date: Sun Jul 19 18:35:33 2015 +0200 combobox: Unconditionally draw background and border gtk/gtkcombobox.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) commit 5f6db9a18267c0ada85d3910d7d00e1fbc4a830d Author: Benjamin Otte Date: Sun Jul 19 18:31:33 2015 +0200 combobox: Remove autoscroll timer on popdown gtk/gtkcombobox.c | 6 ++++++ 1 file changed, 6 insertions(+) commit 19726a5a0eed18c85a1529b2e3d064b4c776f5ae Author: Benjamin Otte Date: Sun Jul 19 05:42:39 2015 +0200 combobox: Remove cell_view_frame Cell views can draw their own frames now. gtk/gtkcombobox.c | 95 ++----------------------------------------------------- 1 file changed, 2 insertions(+), 93 deletions(-) commit 7b57221522543f913f41b9af34ad03842a56ca34 Author: Benjamin Otte Date: Sun Jul 19 05:23:11 2015 +0200 cellview: Implement border and background drawing gtk/gtkcellview.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 70 insertions(+), 8 deletions(-) commit 6f4518ab4b3cdf86f3a2bb1fe0bd08902e0f0abe Author: Stefan Sauer Date: Mon Jul 20 21:02:39 2015 +0200 gtkimagemenuitem: improve the replacement docs even more Since the stock strings usually have menmosics suggest gtk_menu_item_new_with_mnemonic(). gtk/deprecated/gtkimagemenuitem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 173ef4ee660c544ce1d2062c41f6867b00c5b832 Author: Timm Bäder Date: Mon Jul 20 17:04:25 2015 +0200 offscreen_window: Remove deprecated API calls demos/gtk-demo/offscreen_window.c | 4 ---- demos/gtk-demo/offscreen_window2.c | 4 ---- 2 files changed, 8 deletions(-) commit 8a6bad7faf13c3d09a8278662616fc7d05d94e9c Author: Stefan Sauer Date: Mon Jul 20 20:54:52 2015 +0200 gtkimagemenuitem: fix suggestion for replacement gtk_menu_item_new(9 would create an empty menu item. While the stock deprecation aims to unclutter the menus, I feel this goes too far. gtk/deprecated/gtkimagemenuitem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 62af1cbb1d1a947807f635481f80d055d52bd02e Author: Cosimo Cecchi Date: Mon Jul 20 08:21:43 2015 -0700 drawingarea: use same background approach as GtkLayout Call gtk_style_context_set_background() every time the style is updated and add a comment as to why we still need to do it here. https://bugzilla.gnome.org/show_bug.cgi?id=752599 gtk/gtkdrawingarea.c | 32 ++++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) commit 90d237ced46023e3feb8743831966feaa8432397 Author: Cosimo Cecchi Date: Mon Jul 20 08:13:35 2015 -0700 Revert "drawingarea: don't call gtk_style_context_set_background()" This reverts commit 6786c9d724ad57ea30e169d2afcb4a314b2e56bb. https://bugzilla.gnome.org/show_bug.cgi?id=752599 gtk/gtkdrawingarea.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) commit 11ce41d9c423a5339e4e4c4c41a5db20c48e33f0 Author: Cosimo Cecchi Date: Mon Jul 20 08:13:24 2015 -0700 Revert "drawingarea: checks parent's draw() before call it" This reverts commit b3166b745f41a901171821ccc9f0c69b9cc35e70. https://bugzilla.gnome.org/show_bug.cgi?id=752599 gtk/gtkdrawingarea.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit 2dfad2b0d1cad454c4b68625be1e169023aaaed4 Author: Matthias Clasen Date: Mon Jul 20 11:11:00 2015 -0400 file chooser: Memory handling fixes I forgot to clean up the long press gesture, and in additon, creating the rename popover from the ui template was causing the tree view to not be disposed when the file chooser goes away. Work around this by manually unsetting the relative-to widget of the popover in dispose. gtk/gtkfilechooserwidget.c | 16 +++++++--------- gtk/ui/gtkfilechooserwidget.ui | 1 - 2 files changed, 7 insertions(+), 10 deletions(-) commit 50a2428739451bad218940d10c63b604da3b9c21 Author: Ting-Wei Lan Date: Mon Jul 20 21:55:40 2015 +0800 Fix return value error in gtk_stack_get_interpolate_size gtk/gtkstack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fb3adebde203af1880c32028036f6c55b1cb092c Author: Daniel Mustieles Date: Mon Jul 20 12:00:21 2015 +0200 Updated Spanish translation po-properties/es.po | 656 ++++++++++++++++++++++++++-------------------------- 1 file changed, 331 insertions(+), 325 deletions(-) commit 98f4e0656a2067f8141bf454e4d4216b88a55ded Author: Daniel Mustieles Date: Mon Jul 20 12:00:01 2015 +0200 Updated Spanish translation po/es.po | 427 +++++++++++++++++++++++++++++++-------------------------------- 1 file changed, 213 insertions(+), 214 deletions(-) commit 2943bfef4635f10ecf6d09dc215ca771e341e8a6 Author: Jonas Ådahl Date: Mon Jul 20 16:01:32 2015 +0800 wayland: Always apply scaling factor to cursor hotspot and dimension Prior to this patch, the hotspot would be passed in buffer coordinate space. Where this were ever tested, i.e. in a patched mutter, the server interpreted them incorrectly, which meant it went undiscovered. In the updated mutter patches the incorrect behavior in GTK+ was discovered due to the behavior in mutter was corrected. In the themed cursor case, the dimensions were not correctly scaled either, but this had no negative visible effect because the dimension is only used for reporting damage tracking, and passing a bigger damage region than surface has no negative visible effects. https://bugzilla.gnome.org/show_bug.cgi?id=752616 gdk/wayland/gdkcursor-wayland.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) commit ddcb309b5b36c2536cd2c456d33ae9d551666fdc Author: Timm Bäder Date: Sun Jul 19 17:40:28 2015 +0200 GtkPopover: Set interpolate-size on the stack... ... in gtk_popover_bind_model and gtk_popover_menu_init gtk/gtkpopover.c | 1 + gtk/gtkpopovermenu.c | 1 + 2 files changed, 2 insertions(+) commit 469db13b81699b7988aed7be6882b6a9b65f9e74 Author: Timm Bäder Date: Sun Jul 19 17:39:41 2015 +0200 GtkStack: Add interpolate-size property And use it to determine whether we should actually interpolate between stack sizes or not. gtk/gtkstack.c | 98 +++++++++++++++++++++++++++++++++++++++++++++++++--------- gtk/gtkstack.h | 6 +++- 2 files changed, 89 insertions(+), 15 deletions(-) commit 1da92c2800fefebfc37e4bf495e9265af2b87e30 Author: Matthias Clasen Date: Sun Jul 19 22:18:58 2015 -0400 GtkListBox: Improve focus scrolling We are trying to scroll the header in view together with the focus row. The way this is implemented works fine when scrolling up, but falls short when scrolling down. Fix this by making sure that both the row and the header bar visible. gtk/gtklistbox.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) commit 52c4955d211483857cd8a89f7aea28d0183bc19b Author: Matthias Clasen Date: Sun Jul 19 22:08:36 2015 -0400 GtkListBox: Listen for adjustment changes We automatically pick up an adjustment from our parent scrollable, but we failed to update it when it changes. This is happening in the places sidebar, and it was causing the focus-tracking to fail there, letting the focus move out of view. With this change, the focus remains visible. gtk/gtklistbox.c | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) commit 55652b6b09a25ba2f3d6a052e45326b5b8b7f91d Author: Matthias Clasen Date: Sun Jul 19 22:07:21 2015 -0400 places sidebar: Improve keynav Remove the code in the sidebar keypress handler that imperfectly reproduces what GtkListBox already does: moving selection and focus in response to arrow keys. gtk/gtkplacessidebar.c | 28 ---------------------------- 1 file changed, 28 deletions(-) commit bd41c92b283dec5dc916c7a792d994c1d7a98ec0 Author: Matthias Clasen Date: Sun Jul 19 17:39:23 2015 -0400 trivial: Some reformatting gtk/gtkplacessidebar.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) commit 5b5b4de4951b7b9e043e9791135a3221378ad990 Author: Matthias Clasen Date: Sun Jul 19 17:37:39 2015 -0400 places sidebar: Remove pointless code No need to set or unset adjustments explicitly. gtk/gtkplacessidebar.c | 2 -- 1 file changed, 2 deletions(-) commit f263c11ce89fdf6560ee91ccfc711c20eb14271d Author: Matthias Clasen Date: Sun Jul 19 17:17:53 2015 -0400 spin button: Add Home and End as key bindings Make these go to the lower/upper boundary of the adjustment, like Ctrl-PageUp/PageDown already do. https://bugzilla.gnome.org/show_bug.cgi?id=309300 gtk/gtkspinbutton.c | 2 ++ 1 file changed, 2 insertions(+) commit e7fe194b2da4a3614b81ea3275146bca41d5f938 Author: Matthias Clasen Date: Mon Jul 6 00:33:47 2015 -0400 GtkWidget: Add custom font map support This allows to use a custom font map for parts of the widget hierarchy - this can be used for application-specific fonts. https://bugzilla.gnome.org/show_bug.cgi?id=751812 docs/reference/gtk/gtk3-sections.txt | 2 + gtk/gtkwidget.c | 81 ++++++++++++++++++++++++++++++++++-- gtk/gtkwidget.h | 12 ++++-- 3 files changed, 88 insertions(+), 7 deletions(-) commit c9a2e4c0a3c8a444d5e751bc43dd1e6e8c7a965b Author: Matthias Clasen Date: Sun Jul 19 16:52:03 2015 -0400 font chooser: Add placeholder text to preview entry This will make things more understandable if an application sets an empty preview text. https://bugzilla.gnome.org/show_bug.cgi?id=725551 gtk/ui/gtkfontchooserwidget.ui | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit e0f0197d0cf2c447281eb29b6dd07bdde5a3e654 Author: Daniel Hams Date: Thu Jul 16 17:22:07 2015 +0100 GdkGLContext little fix to property names and descriptions. https://bugzilla.gnome.org/show_bug.cgi?id=752502 gdk/gdkglcontext.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit dbeb41eaa20705ec54e49909208bd66690572f90 Author: Matthias Clasen Date: Sun Jul 19 14:04:47 2015 -0400 Updates for 3.17.5 NEWS | 108 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 108 insertions(+) commit defc3d8cbc7e5189c73fa1aad51bc8acc73d132c Author: Matthias Clasen Date: Sun Jul 19 13:18:30 2015 -0400 builder-tool: Don't strip border-width Strictly speaking, this would only have to be special-cased inside GtkDialog, but lets just skip it altogether. gtk/gtk-builder-tool.c | 1 + 1 file changed, 1 insertion(+) commit f881f37789ab265c981554bf997fc7dcd11180c1 Author: Matthias Clasen Date: Sun Jul 19 09:59:18 2015 -0400 Fix csd decorations By accident, commit b9b17c3c2a434983452561c3 removed one line that wasn't unused, but important for hiding close buttons on dialogs. Bring it back. gtk/gtkheaderbar.c | 3 +++ 1 file changed, 3 insertions(+) commit 4fbd9a3d282187b18a523f6861119c94b69aa54d Author: Yosef Or Boczko Date: Sun Jul 19 10:59:19 2015 +0300 Updated Hebrew translation po/he.po | 394 +++++++++++++++++++++++++++++++-------------------------------- 1 file changed, 197 insertions(+), 197 deletions(-) commit 04883e72fa5eae8756710e46917d1c9058baf1f8 Author: Benjamin Otte Date: Sun Jul 19 04:44:17 2015 +0200 window: Set the type hint when it changes, not just on map() There is no reason to wait until map() to reset a type hint on the GDK window. Just set it when it changes. gtk/gtkwindow.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) commit b0ac837271b9584657cf39a7543d8d42a23b057f Author: Benjamin Otte Date: Sun Jul 19 04:40:36 2015 +0200 window: g_object_notify() on type-hint change gtk/gtkwindow.c | 2 ++ 1 file changed, 2 insertions(+) commit 38a07cde75c6a5faaf92fd36b5c2c7d66b703ba7 Author: Benjamin Otte Date: Sun Jul 19 04:39:06 2015 +0200 window: Don't update type hint when it didn't change gtk/gtkwindow.c | 3 +++ 1 file changed, 3 insertions(+) commit 7a16039c2d3da2c4a80ae9fa11a40b274329b317 Author: Benjamin Otte Date: Sun Jul 19 04:37:47 2015 +0200 window: Allow setting type hint on mapped windows gtk/gtkwindow.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 8a238c78862630ce5d9678635ed34356c65965d5 Author: Benjamin Otte Date: Sun Jul 19 04:32:48 2015 +0200 window: Don't keep 2 type hints 1. This confuses the code as it's using the old type hint with the new type hint on GDK window creation 2. It only existed as a workaround for old code that directly accessed window->type_hint which hasn't been possible since 3.0. gtk/gtkwindow.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) commit fbbc203f23b964ebb42ed1b5557d9109d6e15a68 Author: Pedro Albuquerque Date: Sat Jul 18 10:24:02 2015 +0000 Updated Portuguese translation po/pt.po | 539 ++++++++++++++++++++++++++++++++++++--------------------------- 1 file changed, 305 insertions(+), 234 deletions(-) commit 4354b0598a6cc6c3affdaa004bef3707d6a89763 Author: Pedro Albuquerque Date: Sat Jul 18 10:19:20 2015 +0000 Updated Portuguese translation po-properties/pt.po | 855 +++++++++++++++++++++++++++------------------------- 1 file changed, 452 insertions(+), 403 deletions(-) commit c7202b975f0b189fb2f1e9d0553dac95f75a2535 Author: Marek Černocký Date: Sat Jul 18 09:42:25 2015 +0200 Updated Czech translation po-properties/cs.po | 2357 +++++++++++++++++++++++++++------------------------ 1 file changed, 1239 insertions(+), 1118 deletions(-) commit 8d3bcb6ef89cb33c249842e017d266975ad7df63 Author: Benjamin Otte Date: Sat Jul 18 05:39:01 2015 +0200 combobox: Simplify code We don't add new children to the child's parent, we add them to ourself. Because guess who a child's parent is? gtk/gtkcombobox.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) commit d071415d56e507dec36ea39fb48590c5c09ad7c9 Author: Benjamin Otte Date: Sat Jul 18 05:16:07 2015 +0200 combobox: Remove unused header function functionality gtk/gtkcombobox.c | 15 -------- gtk/gtktreemenu.c | 108 +----------------------------------------------------- gtk/gtktreemenu.h | 23 ------------ 3 files changed, 2 insertions(+), 144 deletions(-) commit 1ec7f435d814fd15ee1d8b80b547b6abdf57fa54 Author: Benjamin Otte Date: Sat Jul 18 05:10:39 2015 +0200 combobox: Remove unused argument from private function gtk/gtkcombobox.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) commit c27b90cc79fdb0a5086055161ea3f0882fae30b0 Author: Matthias Clasen Date: Fri Jul 17 20:45:28 2015 -0400 Fix the build gtk/inspector/object-tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7fd307f8815477e85fbe1c689c21d75b3db45ea5 Author: Matthias Clasen Date: Fri Jul 17 20:18:34 2015 -0400 Revert "GtkGrid: Add a few NULL checks" This reverts commit e215db6da21fc7c54f49b247afabc06a18d60513. We are actually requiring non-NULL out arguments here now. gtk/gtkgrid.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) commit ccfacb383ca39d47b70427ffa4b268a5b8baed29 Author: Matthias Clasen Date: Fri Jul 17 19:54:09 2015 -0400 testgtk: Remove pointless code The display is getting overwritten immediately. Pointed out by coverity. tests/testgtk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d8a40c458717d6fdf27da64d66e74ae926ddf766 Author: Matthias Clasen Date: Fri Jul 17 19:52:52 2015 -0400 inspector: Avoid a NULL deref Coverity pointed out that getting a class name requires dereferencing the pointer, so only don't do it if it is NULL. gtk/inspector/object-tree.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 0bb2567ff57c6758684df97a23e032f534b0077a Author: Matthias Clasen Date: Fri Jul 17 19:19:24 2015 -0400 GtkWindow: Fix a use-after-free We were printing a string in a warning after freeing it. Also, fix an x/y typo that might cause popovers to be mispositioned. gtk/gtkwindow.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit a9ee745dc1d756bf3e6169069784629e93c1332c Author: Matthias Clasen Date: Fri Jul 17 19:19:03 2015 -0400 file chooser: remove an unused GError variable Pointed out by coverity gtk/gtkfilechooserwidget.c | 5 ----- 1 file changed, 5 deletions(-) commit 2eb39a3b7ab217e8e9adac9625264c21ae5fca04 Author: Matthias Clasen Date: Fri Jul 17 18:47:39 2015 -0400 inspector: Remove some dead code Not sure what I was thinking here. Coverity pointed this out. gtk/inspector/prop-list.c | 6 ------ 1 file changed, 6 deletions(-) commit ff86433ea1617b73fb0fffec9445ae575119c76a Author: Matthias Clasen Date: Fri Jul 17 18:42:24 2015 -0400 inspector: Avoid a NULL deref gtk/inspector/prop-editor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ee43462d7421fb08fddf2bce0ff5b2c45e3ece96 Author: Matthias Clasen Date: Fri Jul 17 18:41:14 2015 -0400 treeview: Add an explicit return for clarity I believe that first_column can only ever be NULL here if last_column is NULL too, in which case we'd exited already. But coverity doesn't see that, so add an explicit exit. gtk/gtktreeview.c | 3 +++ 1 file changed, 3 insertions(+) commit 0ebcc56a77230984597986a58839f4df1babbd53 Author: Matthias Clasen Date: Fri Jul 17 18:40:37 2015 -0400 tooltip: Remove unnecessary checks Coverity uses these as clues to complain. gtk/gtktooltip.c | 62 +++++++++++++++++++++++++++----------------------------- 1 file changed, 30 insertions(+), 32 deletions(-) commit 361915628df9fc11f019894725772add8b9f3be4 Author: Matthias Clasen Date: Fri Jul 17 18:40:11 2015 -0400 list box: Remove unnecessary checks Again, coverity takes these as clues to complain. gtk/gtklistbox.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit 6a9944cbc57be5b17208a93dc296f83019ad4dd9 Author: Matthias Clasen Date: Fri Jul 17 18:39:14 2015 -0400 GtkLabel: Remove an unnecessary check Coverity has the annoying habit of guessing backwards that if we check the value here, it might be NULL earlier. gtk/gtklabel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e215db6da21fc7c54f49b247afabc06a18d60513 Author: Matthias Clasen Date: Fri Jul 17 18:38:30 2015 -0400 GtkGrid: Add a few NULL checks Coverity complained about these. gtk/gtkgrid.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit 363e791d08996e29231897079bd66da87140fea3 Author: Matthias Clasen Date: Fri Jul 17 18:38:01 2015 -0400 GtkActionHelper: Avoid null deref in debug code gtk/gtkactionhelper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bb29c1fcc5398ae5cc236328ea7d5d6f0fdfb476 Author: Matthias Clasen Date: Fri Jul 17 18:37:20 2015 -0400 gdk: Add some parameter checking This may help coverity recognize that we're not called with invalid combinations. gdk/gdkwindow.c | 2 ++ 1 file changed, 2 insertions(+) commit 2b105dc3d925dc4ad16906afb532968ba6ff9750 Author: Matthias Clasen Date: Fri Jul 17 15:59:23 2015 -0400 testdialog: Error out if templates are missing Coverity complained about us ignoring the return value here, and it is nicer to get an error message about this. tests/testdialog.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit 0ee14211b117725eff658bf78fbabce9039ab443 Author: Matthias Clasen Date: Fri Jul 17 15:58:24 2015 -0400 cups: Annotate a call whose return value we don't care about We're closing this fd, but we're not going to do anything else if that fails. Annotate to let coverity see this. modules/printbackends/file/gtkprintbackendfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1b8d06da2d3f9c5615b2e367335e780c3bbb2947 Author: Matthias Clasen Date: Fri Jul 17 15:56:34 2015 -0400 inspector: Check a return value We don't care about the error here, but we were relying on g_resources_get_info to zero the size even in case of error. No need to do that, we can just check the return value. Plus, it makes coverity happy. gtk/inspector/resource-list.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit f960d4f486aa71f4c8e11ae3c464df1bbb84ed4e Author: Matthias Clasen Date: Fri Jul 17 15:55:18 2015 -0400 inspector: Annotate a call whose return value we don't need The way this code is written, we know that there is an item in the hash table and the iter_next call will give it to us, so no need to check the return value. Annotate the call to tell coverity. gtk/inspector/gestures.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8ba55d80fc90fd21a751b676095e853e6630c0d0 Author: Matthias Clasen Date: Fri Jul 17 15:54:40 2015 -0400 gtkicontheme: Check a return value We were already looking at the error anyway, but rewriting things this way lets coverity see the light. gtk/gtkicontheme.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 91b147622bbd313200b79ab97811b6dc3ba9bdcc Author: Matthias Clasen Date: Fri Jul 17 15:52:22 2015 -0400 gtkbuilderparser: Add some assertions Add some assertions that things are non-NULL when we know they are, so that coverity gets it. gtk/gtkbuilderparser.c | 3 +++ 1 file changed, 3 insertions(+) commit 770fc90e7cf24e2406a8c778596c79f94ebb3a2e Author: Matthias Clasen Date: Fri Jul 17 15:51:05 2015 -0400 gtk-demo: Check a return value Found by coverity. demos/gtk-demo/main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 6c862f229fa54b6377856409b4b12ed362f8bf87 Author: Benjamin Otte Date: Fri Jul 17 22:06:16 2015 +0200 css: Fix GtkCssChange enum Previously, the (1<<31) value evaluated to the 64bit value 0xFFFFFFFF80000000 instead of 0x0000000080000000 Avoid this by explicitly casting the value to unsigned long long. Also cast all values to unsigned long long to achieve consistency and hopefully in the future get new values added the same way. gtk/gtkcsstypesprivate.h | 70 ++++++++++++++++++++++++------------------------ 1 file changed, 35 insertions(+), 35 deletions(-) commit dbb183072804b3a498d84cb6c98f5f93a6f6c8c5 Author: Benjamin Otte Date: Fri Jul 17 17:50:25 2015 +0200 headerbar: Switch css positions on direction change gtk/gtkheaderbar.c | 10 ++++++++++ 1 file changed, 10 insertions(+) commit 048051788676c7d8c4213d3e49aa40cec805bf70 Author: Balázs Úr Date: Fri Jul 17 14:25:22 2015 +0000 Updated Hungarian translation po-properties/hu.po | 1760 +++++++++++++++++++++++++++------------------------ 1 file changed, 918 insertions(+), 842 deletions(-) commit 9b81372ad9ffc005673bead2b4b42e7898138870 Author: Matthias Clasen Date: Fri Jul 17 08:56:06 2015 -0400 file chooser: Improve popover positioning We keep the popover vertically tied to the selected row, but pick up the horizontal position from the click / touch. gtk/gtkfilechooserwidget.c | 47 ++++++++++++++++++++++++---------------------- 1 file changed, 25 insertions(+), 22 deletions(-) commit 7627ed8000ed705af3f963d861f5dd230902cd1f Author: Matthias Clasen Date: Thu Jul 16 19:27:01 2015 -0400 places sidebar: Preserve ::populate-popup functionality We "fix" this signal the same way we did for GtkEntry and GtkTextView: slightly change the signature so that the passed widget may be a container other than a GtkMenu, and add a property to explicitly opt in to receiving the signal in this case. gtk/gtkplacessidebar.c | 105 ++++++++++++++++++++++++++++++++++++------------- 1 file changed, 78 insertions(+), 27 deletions(-) commit 33cc51d9942d66b3a0ea01097a65825c0fd6635f Author: Matthias Clasen Date: Thu Jul 16 10:45:14 2015 -0400 file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch. gtk/gtkfilechooserwidget.c | 508 +++++++++++++++++++++++---------------------- 1 file changed, 255 insertions(+), 253 deletions(-) commit e08c5262b728471934d15fef5389b74a1eefbd15 Author: Matthias Clasen Date: Wed Jul 15 21:25:10 2015 -0400 places sidebar: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch. gtk/gtkplacessidebar.c | 482 +++++++++++++++++++++++-------------------------- 1 file changed, 224 insertions(+), 258 deletions(-) commit 186c8f5254a7b9b29df6d9708a5d10f869d6829d Author: Ignacio Casal Quinteiro Date: Fri Jul 17 09:31:32 2015 +0200 gdk: fix crash if visual is NULL cairo_xlib_surface_get_visual might return NULL so we need to check for NULL before trying to use it. https://bugzilla.gnome.org/show_bug.cgi?id=752520 gdk/x11/gdkglcontext-x11.c | 3 +++ 1 file changed, 3 insertions(+) commit 02577ddb06d9fe9f9ddc2813d15f8c2100e31c36 Author: Matthias Clasen Date: Thu Jul 16 23:42:55 2015 -0400 inspector: Avoid a gratitious use of g_strv_length No need to count the strings first before iterating over them. gtk/inspector/selector.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 1fb075dbca911d4a61e7ebbf9fc040cd697f4d83 Author: Matthias Clasen Date: Thu Jul 16 23:36:51 2015 -0400 file chooser: Make bindings work in save entry With the name entry being in the header bar now, we no longer get bindings working by just letting the key event bubble up, we have to explicitly apply them on key events that the save entry is not handling. gtk/gtkfilechooserwidget.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) commit c53bed3b391f42c85fb62c029005d086d43686b0 Author: Timm Bäder Date: Thu Jul 16 21:47:13 2015 +0200 GtkFileChooserButton: Don't update icon/label so often They were updated in style-changed, causing the label to get set to (None), then to the actual file name again a frame later, both of the updates cause the GtkFileChooserButton to resize, possibly to the minimal width, causing the layout to jump. Fix this by only updating icon/label in style-updated when the icon theme actually changed, which is the only case we care about here. https://bugzilla.gnome.org/show_bug.cgi?id=752509 gtk/gtkfilechooserbutton.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) commit 2902585518e0c175e75ec4d9657594a904e2eb0a Author: Timm Bäder Date: Thu Jul 16 18:37:13 2015 +0200 gtkprintunixdialog: Set border_width to 0 gtk/ui/gtkprintunixdialog.ui | 1 + 1 file changed, 1 insertion(+) commit e259b2f30d86fdde7dab27a25e8088d36421acc7 Author: Emmanuele Bassi Date: Thu Jul 16 16:12:35 2015 +0100 Avoid O(n²) walking of string arrays "Yo, we heard you like traversing NULL-terminated arrays to operate on them, so we called g_strv_length() as the for condition, so you can iterate the array while iterating the array." Instead of making famed rapper and television producer Xzibit proud, we should avoid calling g_strv_length() on an array while looping on the array, to avoid quadratic complexity. We do this in various places that deal with arrays of strings that we cannot really guess are short enough not to matter — e.g. the list of CSS selectors in the inspector, or the required authentication information for printing. gtk/gtkprintbackend.c | 25 +++++++++++++----------- gtk/inspector/selector.c | 5 +++-- modules/printbackends/cups/gtkcupssecretsutils.c | 5 +++-- testsuite/a11y/state/state-record.c | 7 ++++--- 4 files changed, 24 insertions(+), 18 deletions(-) commit 3b41daca780e9e83d04dcad43e2fbd5a2ab8c120 Author: Georges Basile Stavracas Neto Date: Thu Jul 16 10:28:19 2015 -0300 placessidebar: show persistent drives when not showing Other Locations Previous commits changes the behavior of GtkPlacesSidebar, as it stops handling persistent devices and only manages mounted networks, XDG directories and bookmarks. By radically breaking the previous behavior, we may have trouble since we provide no alternatives to that besides the private widget GtkPlacesView. Fix that by showing the persistent devices when not showing Other Locations item. gtk/gtkplacessidebar.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) commit b274a2656d06ed7aa3e649e93988de86af048957 Author: Emmanuele Bassi Date: Thu Jul 16 14:53:42 2015 +0100 tests/gears: Ensure we don't use unavailable GL resources We need to check on realize if we have access to a GL context, before calling GL functions. We use gtk_gl_area_get_error() for that. We also need to tear down the resources during unrealization, instead of leaking them. tests/gtkgears.c | 122 +++++++++++++++++++++++++++++++++++++++---------------- 1 file changed, 87 insertions(+), 35 deletions(-) commit a39b8f67ba914cd2d6c2df50ce8b1659d9714d30 Author: Georges Basile Stavracas Neto Date: Thu Jul 16 09:37:56 2015 -0300 placessidebar: fix Connect to Server position Commit 7db399d975b8f9626c21761dde5f2d5feeb6e305 introduces the Other Locations item, as well as some behavioral changes to GtkPlacesSidebar. It, howevers, wrongly changes the section of code that handles the Connect to Server item, with various side effects depending on the environment setup. Fix that by adding the Connect to Server at the right section of code. gtk/gtkplacessidebar.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) commit 40efaf67bfa759f854145010ddb7fff341eece2f Author: Yosef Or Boczko Date: Thu Jul 16 12:59:49 2015 +0300 Updated Hebrew po-properties translation po-properties/he.po | 2105 +++++++++++++++++++++++++++------------------------ 1 file changed, 1105 insertions(+), 1000 deletions(-) commit 0916b58d02e054193be0db45b8e7736621e93460 Author: Yosef Or Boczko Date: Thu Jul 16 12:54:42 2015 +0300 Updated Hebrew translation po/he.po | 36 ++++++++++++++++-------------------- 1 file changed, 16 insertions(+), 20 deletions(-) commit 09baf865b6f6df95ac3de2f51476f34392ee8e43 Author: Yosef Or Boczko Date: Thu Jul 16 12:44:56 2015 +0300 Updated Hebrew translation po/he.po | 750 ++++++++++++++++++++++++++++++++++++++++++--------------------- 1 file changed, 506 insertions(+), 244 deletions(-) commit 9a0fcfe081f736493aa33fce7fb0587bcf64232e Author: Daniel Mustieles Date: Thu Jul 16 10:41:16 2015 +0200 Updated Spanish translation po-properties/es.po | 205 +++++++++++++++++++++++++++++++++------------------- 1 file changed, 130 insertions(+), 75 deletions(-) commit a2a227f939dbd960d7e3961d2ac12041d20a2e06 Author: Daniel Mustieles Date: Thu Jul 16 10:40:58 2015 +0200 Updated Spanish translation po/es.po | 370 ++++++++++++++++++++++++++++++++++++++------------------------- 1 file changed, 221 insertions(+), 149 deletions(-) commit 5b8938440bdcf9affd4a252be69f2142a1827591 Author: Piotr Drąg Date: Thu Jul 16 06:49:33 2015 +0200 Updated POTFILES.in and POTFILES.skip po-properties/POTFILES.in | 2 ++ po-properties/POTFILES.skip | 2 ++ po/POTFILES.in | 4 ++++ 3 files changed, 8 insertions(+) commit bc19ea965fb23a782f691c82139c807e828646a7 Author: Benjamin Otte Date: Thu Jul 16 06:37:37 2015 +0200 tests: Remove testplacesview test The GtkPlacesView widget was made private, so we can't create it in a testcase. tests/Makefile.am | 5 ----- tests/testplacesview.c | 2 ++ 2 files changed, 2 insertions(+), 5 deletions(-) commit 974c60a0d50523fa8e09d13e2d6d9ba535b2ace8 Author: Benjamin Otte Date: Thu Jul 16 06:25:46 2015 +0200 tests: Fix gcc complaints about testfilechooser tests/testfilechooser.c | 71 ++++++++++++++++++++++++++----------------------- 1 file changed, 37 insertions(+), 34 deletions(-) commit 3d2ead0fce07d571b56d0118a3419d658457afde Author: Benjamin Otte Date: Thu Jul 16 03:22:40 2015 +0200 headerbar: Get rid of get_path_for_child() Instead, reorder CSS nodes. gtk/gtkcontainer.c | 4 +- gtk/gtkcontainerprivate.h | 1 - gtk/gtkheaderbar.c | 108 +++++++++++++++++++++++----------------------- 3 files changed, 57 insertions(+), 56 deletions(-) commit a039fd1699389d006dd7ab3b4bb811368f03a5e0 Author: Benjamin Otte Date: Wed Jul 15 01:51:01 2015 +0200 headerbar: Finish widget setup before showing it. gtk/gtkheaderbar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 792076e09b482e1db06e104e0fc11e69b4fdd122 Author: Benjamin Otte Date: Tue Jul 14 22:27:13 2015 +0200 headerbar: forall() the button boxes in the right order gtk/gtkheaderbar.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit b9b17c3c2a434983452561c396918070c9702f5e Author: Benjamin Otte Date: Tue Jul 14 18:02:48 2015 +0200 headerbar: Remove unused variables in private struct gtk/gtkheaderbar.c | 36 ------------------------------------ 1 file changed, 36 deletions(-) commit 8e87988179defdc7fd056300fb418d2a5f4c44a7 Author: Benjamin Otte Date: Sun Jul 12 23:11:24 2015 +0200 toolbar: Switch from get_path_for_child() to css node managing gtk/gtktoolbar.c | 158 +++++-------------------------------------------------- 1 file changed, 13 insertions(+), 145 deletions(-) commit a7680c68de3cc5012ac7a63658c051f1771e8af9 Author: Benjamin Otte Date: Sun Jul 12 23:11:11 2015 +0200 cssnode: Add gtk_css_node_reverse_children() gtk/gtkcssnode.c | 15 +++++++++++++++ gtk/gtkcssnodeprivate.h | 2 ++ 2 files changed, 17 insertions(+) commit 6e4f42f97e4b61d9fb2c3e8ecc0ac9baa3eb890b Author: Benjamin Otte Date: Sun Jul 12 21:39:49 2015 +0200 cssnode: Change API of some functions gtk_css_node_set_after/before() are now called gtk_css_node_insert_after/before(). This brings them in line with other similar APIs (ie GtkListStore). And it allows easier usage of the API (see changes to gtkbox.c). gtk/gtkbox.c | 45 +++++++++++++++++++++------------------------ gtk/gtkcssnode.c | 26 +++++++++++++++++--------- gtk/gtkcssnodeprivate.h | 6 ++++-- gtk/gtkflowbox.c | 12 ++++++------ gtk/gtklistbox.c | 12 ++++++------ 5 files changed, 54 insertions(+), 47 deletions(-) commit 79f2400c0dd769755b8e2034a9d574f567987c0d Author: Georges Basile Stavracas Neto Date: Tue Jul 14 14:48:49 2015 -0300 filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034 gtk/gtkfilechooserwidget.c | 81 ++++++++++++++++++++++++++++++++++++++---- gtk/ui/gtkfilechooserwidget.ui | 13 +++++++ 2 files changed, 87 insertions(+), 7 deletions(-) commit 7db399d975b8f9626c21761dde5f2d5feeb6e305 Author: Georges Basile Stavracas Neto Date: Tue Jul 14 14:47:42 2015 -0300 placessidebar: add Other Locations item Places sidebar is a widget that enabled the user to select XDG directories, bookmarks and mounted network locations, as well as manages permanent and removable devices. The new design that aims to look less clutered makes the sidebar display only removable devices, as well as mounted networks, bookmarks and XDG directories, and delegates the management of permanent devices such as hard drive partitions to GtkPlacesView, a newly introduced widget for this specific purpose. To delegate it, add an "Other Locations..." item to notify when the permanent devices manager is required. Besides that, don't show these fixes devices on the sidebar itself, as they are not supposed to be handled by the sidebar anymore. https://bugzilla.gnome.org/show_bug.cgi?id=752034 gtk/gtkplacessidebar.c | 227 +++++++++++++++++++++++++++++++++--------- gtk/gtkplacessidebar.h | 10 +- gtk/gtkplacessidebarprivate.h | 5 +- 3 files changed, 193 insertions(+), 49 deletions(-) commit 7af88d40b14f5793b975eab34e727ae4535d0cb7 Author: Georges Basile Stavracas Neto Date: Tue Jul 14 14:45:37 2015 -0300 placesview: add view for fixed drives and networks Places sidebar shows XDG directories, mounted and unmounted devices, connected networks, bookmarks and actions like 'Connect to server' and 'Insert location', which causes the sidebar to grow very quickly and look cluttered. Because of that, new mockups for the sidebar try to simplify it. To make the sidebar simpler, the new mockups propose that it should only handle connected networks and removable devices such as flash drives and USB devices, and delegates other devices for external widgets through the 'Other Locations' item. To handle fixed devices and manage network connections, add a new widget named GtkPlacesView, based on Nautilus mockups to keep consistency between GNOME file management tools - in this case, between Nautilus and the bundled Gtk's file chooser. https://bugzilla.gnome.org/show_bug.cgi?id=752034 gtk/Makefile.am | 6 + gtk/gtkplacesview.c | 2028 +++++++++++++++++++++++++++++++++++++++++ gtk/gtkplacesviewprivate.h | 93 ++ gtk/gtkplacesviewrow.c | 246 +++++ gtk/gtkplacesviewrowprivate.h | 51 ++ gtk/ui/gtkplacesview.ui | 504 ++++++++++ gtk/ui/gtkplacesviewrow.ui | 107 +++ tests/Makefile.am | 5 + tests/testplacesview.c | 24 + 9 files changed, 3064 insertions(+) commit 72bfb40ccf746f743d9818f9dbecf2820f4557ba Author: Carlos Garnacho Date: Wed Jul 15 21:19:25 2015 +0200 Revert "x11: Query pointer devices' scroll valuators on toplevel enter events" This reverts commit 77b8495bc4e51826afa451914d6a3b0df1b62a24. The commit broke more scenarios than fixed, better to go back to square one. gdk/x11/gdkdevice-xi2.c | 39 ++++++++++++++++----------------------- gdk/x11/gdkdevicemanager-xi2.c | 15 ++++++++++----- gdk/x11/gdkprivate-x11.h | 2 -- 3 files changed, 26 insertions(+), 30 deletions(-) commit 6504b2e53468004c7936e7f79fba03291dc58128 Author: Owen W. Taylor Date: Wed Jul 15 12:38:38 2015 -0400 GdkDisplayX11: Properly translate server timestamps from _NET_WM_FRAME_* messages When using frame times from _NET_WM_FRAME_DRAWN and _NET_WM_FRAME_TIMINGS, we were treating them as local monotonic times, but they are actually extended-precision versions of the server time, and need to be translated to monotonic times in the case where the X server and client aren't running on the same system. This fixes rendering stalls when using X over a remote ssh connection. https://bugzilla.gnome.org/show_bug.cgi?id=741800 gdk/x11/gdkdisplay-x11.c | 43 ++++++++++++++++++++++++++++++++++++++++++- gdk/x11/gdkdisplay-x11.h | 6 ++++++ 2 files changed, 48 insertions(+), 1 deletion(-) commit 24e1323eb33f22c1126d1701639b2605c4443868 Author: Matthias Clasen Date: Wed Jul 15 01:44:31 2015 -0400 places sidebar: Handle menu key It is good practice to handle the menu key and Shift-F10 to allow keyboard-driven use of context menus. gtk/gtkplacessidebar.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) commit bd71b801de54218907bf4211e6ef506eec23c967 Author: William Hua Date: Mon Jul 13 08:55:43 2015 -0400 mir: don't ensure_surface if window not visible gdk/mir/gdkmirwindowimpl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 064f28fcbc54c7254e36d2a2e9b2771ce754f988 Author: William Hua Date: Thu Jul 9 15:59:29 2015 -0400 mir: don't warn if transient_for is NULL gdk/mir/gdkmirwindowimpl.c | 2 -- 1 file changed, 2 deletions(-) commit b32899b98a5c24e44bb8a0e53677d8cc226d1754 Author: William Hua Date: Thu Jul 9 15:05:45 2015 -0400 mir: add more default settings under mir gdk/mir/gdkmirscreen.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) commit 88b278b45cac388b73a40bb90c2c3a2b593366b7 Author: Pedro Albuquerque Date: Wed Jul 15 10:02:38 2015 +0000 Updated Portuguese translation po/pt.po | 172 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 88 insertions(+), 84 deletions(-) commit 34388d147f7c3f4cad6737da2146963e2ed9ea39 Author: Daniel Mustieles Date: Wed Jul 15 11:13:29 2015 +0200 Updated Spanish translation po/es.po | 104 +++++++++++++++++++++++++-------------------------------------- 1 file changed, 41 insertions(+), 63 deletions(-) commit e7c0bb6025b117ff36cc33740156f1f891aecde3 Author: Matthias Clasen Date: Wed Jul 15 00:15:44 2015 -0400 file chooser: Show progess spinner even if not empty With the previous approach, we could only show the spinner before we had any results. With the new approach, we can just leave the timeout in place and always show the spinner until the search is done. gtk/gtkfilechooserwidget.c | 6 ------ 1 file changed, 6 deletions(-) commit 6d757750f1e8daabb0704f960aa5481f6bef1ca1 Author: Matthias Clasen Date: Wed Jul 15 00:12:33 2015 -0400 file chooser: Stop search when entry is cleared gtk/gtkfilechooserwidget.c | 2 ++ 1 file changed, 2 insertions(+) commit 5bd60131651ee6241f7afc46e34f6600f352945c Author: Matthias Clasen Date: Wed Jul 15 00:03:09 2015 -0400 file chooser: Refine search progress display Move the spinner to the search bar, so we can keep it around until the search is over. gtk/gtkfilechooserwidget.c | 26 ++++++++++++-------------- gtk/ui/gtkfilechooserwidget.ui | 17 +++++++++-------- 2 files changed, 21 insertions(+), 22 deletions(-) commit eb67d14551a5d77dc3519689923e788c21050800 Author: Matthias Clasen Date: Tue Jul 14 23:48:09 2015 -0400 file chooser: Be more careful with subtitles We were showing things like "Searching in (null)" if the current folder is not in the sidebar. Avoid that by falling back to using current_folder. Pointed out by Carlos Soriano. gtk/gtkfilechooserwidget.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) commit a00a5ed2104b516200c13c40be3ffa174d87fd91 Author: Ryan Lortie Date: Mon Jul 6 14:08:11 2015 -0400 GtkApplication: avoid using stale timestamps Avoid using a stale timestamp (from the last user interaction with the application) when a message arrives from D-Bus requesting that a new window be created. In this case the most-correct thing that we can do is to use no timestamp at all. We modify gdk_x11_display_set_startup_notification_id() to allow a NULL value to mean "reset everything" and then call this function unconditionally on receipt of D-Bus activation requests. The result will be that a missing desktop-startup-id in the platform-data struct will reset the timestamp. Under their default configuration metacity and mutter will both map windows presented with no timestamp in the foreground. This could result in false-positive, but there is very little we can do about that without the original timestamp from the user event. https://bugzilla.gnome.org/show_bug.cgi?id=752000 gdk/x11/gdkdisplay-x11.c | 57 +++++++++++++++++++++++++++++------------------- gtk/gtkapplication-x11.c | 13 +++++------ 2 files changed, 39 insertions(+), 31 deletions(-) commit 18dbe181fb13571ecbc76ce7f7f28c36c557a3d6 Author: Jasper St. Pierre Date: Tue Jul 14 18:24:42 2015 -0700 gtkframe: Don't queue a redraw on the entire widget every size allocate Lots of applications often use GtkFrame as a giant toplevel container, and that means that they get size allocated often. When frames get size allocated, they invalidate their entire widget tree, even if they haven't changed size or anything like that happens at all. This is because the shadow / label needs to be redrawn if the child changes size. We can optimize this out and only mark ourselves for a redraw if the child has actually changed its size. gtk/gtkframe.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) commit 2dda89cbd52e09cfbc24a9139caa7a65a5f73f2c Author: Lars Uebernickel Date: Wed Jul 8 16:36:07 2015 +0200 GtkButtonBox: remove spacing when buttons are linked GtkButtonBox adds the "linked" class to its style context when its layout is set to GTK_BUTTONBOX_EXPAND. It shouldn't ever make sense to have spacing between buttons in that case, as themes generally draw linked elements with a continuous border. Thus, always set spacing to 0 and ignore GtkDialog's button-spacing style property when the layout is set to EXPAND. Also remove the now-redundant css rules which set button-spacing to 0 for message dialogs. https://bugzilla.gnome.org/show_bug.cgi?id=752131 gtk/gtkbbox.c | 1 + gtk/gtkbbox.h | 5 ++++- gtk/gtkdialog.c | 5 +++-- gtk/theme/Adwaita/_common.scss | 2 -- gtk/theme/HighContrast/_common.scss | 1 - 5 files changed, 8 insertions(+), 6 deletions(-) commit 0f479deb5eb90fe131a91b7e6d0a8df7f93fec2a Author: Matthias Clasen Date: Mon Jul 13 18:56:34 2015 -0400 range: Tweak button bindings Change things around so that warp-to-click and jump-by-pages are bound to left-click and shift-left-click, depending on the value of gtk-primary-button-warps-slider. Autoscrolling is bound to right-click. To achieve this, reorganize gtk_range_multipress_gesture_pressed so that the functions are clearly separated. gtk/gtkrange.c | 157 ++++++++++++++++++++++++++++----------------------------- 1 file changed, 78 insertions(+), 79 deletions(-) commit 437254d20f9d54ebfdd267611fdbb6f6feb1917e Author: Daniel Mustieles Date: Mon Jul 13 10:51:18 2015 +0200 Updated Spanish translation po-properties/es.po | 1659 ++++++++++++++++++++++++++------------------------- 1 file changed, 849 insertions(+), 810 deletions(-) commit c45941300537df412d4f206262744f9bc1de97e7 Author: Daniel Mustieles Date: Mon Jul 13 10:51:05 2015 +0200 Updated Spanish translation po/es.po | 729 +++++++++++++++++++++++++++++++++++++++++---------------------- 1 file changed, 475 insertions(+), 254 deletions(-) commit 6b05a686dcc406aaf84ffb56ae5fa2d5c83f45ae Author: Kalev Lember Date: Sun Jul 12 20:18:17 2015 +0200 GtkSettings: Fix a documentation typo gtk/gtksettings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1ca6d8b1b586ea6d11c481b442862dab30ae0a8a Author: Matthias Clasen Date: Sun Jul 12 01:53:36 2015 -0400 range: Trivial field ordering gtk/gtkrange.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) commit 1c780beb8b194d18ff86ca53f30b0c6c522bfc0d Author: Matthias Clasen Date: Sun Jul 12 01:36:17 2015 -0400 range: Add a stepper alternative Make shift right-click on the trough start autoscrolling. The autoscrolling is similar to the way steppers operate now, with the difference that we vary the scrolling speed based on the distance of the pointer from the widget. gtk/gtkrange.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 50 insertions(+), 10 deletions(-) commit 6e280d2478c7c592688f931c032972f2df03cdb2 Author: Matthias Clasen Date: Sun Jul 12 00:23:32 2015 -0400 range: switch secondary and middle button on steppers Clicking on steppers does different things depending on which button you use. We used to scroll to the end on secondary click and use high-speed autoscrolling on middle-click. Switch these two around, since the scroll-to-end functionality is less likely to be useful, and the seconary button makes the autoscrolling more easily available. gtk/gtkrange.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit f35c7b83d9938957e148c86105fabce8ec410c2d Author: Matthias Clasen Date: Thu Jul 9 09:10:10 2015 -0500 font chooser: Remove a stray notify This was forgotten when I changed to font map to not be a property. gtk/gtkfontchooserwidget.c | 2 -- 1 file changed, 2 deletions(-) commit 301cf24b336550237f351a46ce38e5683ec06ece Author: Matthias Clasen Date: Wed Jul 8 21:47:47 2015 -0400 file chooser: Clean up unused includes gtk/gtkfilechooserwidget.c | 17 ----------------- 1 file changed, 17 deletions(-) commit 995e87322c01d22290e122a88d8d1ff3091ce1a3 Author: Matthias Clasen Date: Wed Jul 8 21:37:47 2015 -0400 file chooser: Remove some obsoltete code We no longer have editable rows in the list, so no need to check for them anymore. gtk/gtkfilechooserwidget.c | 19 ------------------- 1 file changed, 19 deletions(-) commit 0c7237f15ee8271502e99b062cc4780b499d8397 Author: Matthias Clasen Date: Wed Jul 8 21:31:40 2015 -0400 file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems. gtk/gtkfilechooserwidget.c | 240 +++++++++++++++++++++++---------------------- 1 file changed, 125 insertions(+), 115 deletions(-) commit 24dc6f877120787fafb01bc6a3dc5b1c914ba21f Author: Matthias Clasen Date: Wed Jul 8 21:09:23 2015 -0400 file chooser: Do less work We only need to update the sensitivity of the context menu items rihgt before we are going to pop it up. Everything else is pointless work. gtk/gtkfilechooserwidget.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit 201d4c110186dcfa77f2cee2bed88f1674c52f54 Author: Matthias Clasen Date: Wed Jul 8 21:06:58 2015 -0400 file chooser: Avoid doing excess work Whenever we change directories, we unset the model, and then we set a new model. This causes several emissions of GtkTreeSelection::changed, for each of which we do a bunch of work to update the path bar, the location entry, etc. We can savely ignore some of these signals, and do less work. gtk/gtkfilechooserwidget.c | 3 +++ 1 file changed, 3 insertions(+) commit 72a8064c7d1ebf3bffb20b0f4c3092d7ae4fb1cf Author: Matthias Clasen Date: Wed Jul 8 20:32:03 2015 -0400 Trivial code cleanup gtk/gtkfilechooserwidget.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit 410d180b459405e191265cbacd5aa4b1b27dc9df Author: Matthias Clasen Date: Wed Jul 8 20:15:07 2015 -0400 file chooser: Avoid animations when setting up There is no need to animate things when we are just setting up the startup mode, so disable transitions in the revealer and the stack. Pointed out by Carlos Soriano gtk/gtkfilechooserwidget.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) commit e43ba9d726658123036b6c49ee0c2be011adefab Author: Matthias Clasen Date: Wed Jul 8 17:42:34 2015 -0400 file chooser: Ensure we update subtitles Notify the ::subtitle property when modes change that may affect it. Also ensure that we update the location mode when we switch back to the pathbar. gtk/gtkfilechooserwidget.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 190f025f74d41e2cbee82615e7305b62faab044e Author: Benjamin Otte Date: Fri Jul 10 21:34:41 2015 +0200 cssnode: Only queue_validate() when node is visible This avoids running animations in hidden toplevels. gtk/gtkcssnode.c | 37 ++++++++++++++++++++++++++++--------- 1 file changed, 28 insertions(+), 9 deletions(-) commit adcb52e82bf9c6545718a3c4d00c171aba6b20d4 Author: Benjamin Otte Date: Fri Jul 10 21:34:06 2015 +0200 cssnode: Only invalidate sibling nodes if changed node is visible gtk/gtkcssnode.c | 35 +++++++++++++++++++++++++---------- 1 file changed, 25 insertions(+), 10 deletions(-) commit c05cd611e6e31813648ec1bd4d7b7139b8f1fca2 Author: Pedro Albuquerque Date: Fri Jul 10 08:37:25 2015 +0000 Updated Portuguese translation po/pt.po | 202 +++++++++++++++++++++++++++++++-------------------------------- 1 file changed, 101 insertions(+), 101 deletions(-) commit 60384740603c3e8a0fda8e823ac6df19352077e5 Author: Eric Williams Date: Tue Jul 7 14:54:32 2015 -0400 Added an additional explanation and code snippet for GtkImageMenuItem.c https://bugzilla.gnome.org/show_bug.cgi?id=752093 gtk/deprecated/gtkimagemenuitem.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) commit a74a3da745e6923b0d5f04073f40446a310aec40 Author: Eric Williams Date: Tue Jul 7 13:12:52 2015 -0400 Added a more meaningful description for /deprecated/gtkimagemenuitem.c https://bugzilla.gnome.org/show_bug.cgi?id=752088 gtk/deprecated/gtkimagemenuitem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8e53a011885adc749dc67e3553f21f9fbe4404e3 Author: Matthias Clasen Date: Tue Jul 7 23:16:09 2015 -0400 places sidebar: Fix rows getting 'lost' when dnd fails There was some code that lead to the places sidebar loosing track of the row being dragged if a motion event came in between letting go of the button and the drag snap-back animation ending. This would cause us to not show the row again, giving the appearance that it was 'lost'. https://bugzilla.gnome.org/show_bug.cgi?id=751448 gtk/gtkplacessidebar.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) commit 8756c03885a7dbeb6d075ab270112cf66079db3a Author: Benjamin Otte Date: Tue Jul 7 21:38:59 2015 +0200 testtoolbar: Don't expand rows that shouldn't be expanded tests/testtoolbar.c | 2 -- 1 file changed, 2 deletions(-) commit 0f6c9557959c9111714cee712d233ac3afc86657 Author: Benjamin Otte Date: Tue Jul 7 18:53:10 2015 +0200 frame: Remove get_path_for_child implementation As far as I can read the code it added the .frame style class to the GtkFrame element. But GtKFrame already has a .frame style class these days. gtk/gtkframe.c | 20 -------------------- 1 file changed, 20 deletions(-) commit 6379a425b069eeab32c052b42a60908e0d0e5fb7 Author: Benjamin Otte Date: Tue Jul 7 18:16:39 2015 +0200 actionbar: Remove get_path_for_child implementation It wasn't used because CSS walks the widget->parent chain, so it'd only ever call this func for priv->revealer. gtk/gtkactionbar.c | 13 ------------- 1 file changed, 13 deletions(-) commit 7f8de66c0a85dcf114068348d728eeb3b67e8762 Author: Benjamin Otte Date: Tue Jul 7 17:51:31 2015 +0200 css: text-decoration-style is not inherited gtk/gtkcssstylepropertyimpl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit bdf0820c501437a2150d8ff0d5340246e713f73f Author: Matthias Clasen Date: Tue Jul 7 20:39:45 2015 -0400 Simplify Xft setting fallback If we don't find Xft values in the X resource db, simply fall back to the values that are hardcoded in /etc/X11/Xresources anyway. Extra trickery with likely-made-up screen dimensions is not going to yield better results, and only makes for a deeper rabbit hole when debugging. gdk/x11/gdkxftdefaults.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 3fb1d1806d0137396eef2ae63df13005be91a010 Author: Carlos Soriano Date: Tue Jul 7 22:57:51 2015 +0200 gtksidebarrow: remove unused property The sensitive property was a workaround which commit 3f8982a0cd7b779fe023bbd fixed. Just remove it now that is not necessary. gtk/gtksidebarrow.c | 28 ---------------------------- 1 file changed, 28 deletions(-) commit 0f935a04835d3239726610168e202c5110921090 Author: Carlos Soriano Date: Tue Jul 7 22:47:10 2015 +0200 gtkrevealer: fix preferred width calculation A typo which was using minimum_width for natural_width and viceversa. gtk/gtkrevealer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit d51e8a73cb513e0df337d577daefb9f1fa3832f7 Author: Piotr Drąg Date: Tue Jul 7 21:51:55 2015 +0200 Fix a minor typo gtk/gtkfilechooserwidget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 254f13d103ae9133ca6b0ed088a0ae3da7cc6e74 Author: Piotr Drąg Date: Tue Jul 7 20:26:24 2015 +0200 Updated Polish translation po-properties/pl.po | 4393 ++++++++++++++++++++++++++------------------------- 1 file changed, 2216 insertions(+), 2177 deletions(-) commit 7d43cda4934779e7529a905db2762a92eeda2f0b Author: Tom Schoonjans Date: Mon Jul 6 17:34:37 2015 +0200 gdkwindow-quartz: partial aspect ratio support Support was added for GDK_HINT_ASPECT in gdk_quartz_window_set_geometry_hints though with one restriction: min_aspect and max_aspect have to be equal, which I believe corresponds to the most common usage. A warning will be printed if this condition is not met but min_aspect will be used anyway. gdk/quartz/gdkwindow-quartz.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit d2f27bfe7126c4ee726ec4510e9a70521ce87277 Author: Ryan Lortie Date: Mon Jul 6 09:40:48 2015 -0400 testgmenu: use the menu binding code The menu tracker does a better job of this than we can, so move over to using it instead. This fixes issues with './testgmenu --import' not properly displaying the language submenu. https://bugzilla.gnome.org/show_bug.cgi?id=752016 tests/testgmenu.c | 387 ++---------------------------------------------------- 1 file changed, 14 insertions(+), 373 deletions(-) commit 9e2092d3063744dde05827b5d42442bb82c00796 Author: Carlos Garnacho Date: Tue Jul 7 12:50:14 2015 +0200 gtkdnd: Fix introspection annotations in some functions The GdkEvent field is nullable on gtk_drag_begin*, and gtk_drag_cancel() is a method, like the rest of the DnD API. gtk/gtkdnd.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit dadb2750b1ff288c5627f472faf94b33b1f355bb Author: Carlos Garnacho Date: Mon Jul 6 19:33:49 2015 +0200 gtkdnd: Account for setting a same icon helper g_set_object() will take care of ref'ing before destroying the previous instance, which might actually be the same pointer. https://bugzilla.gnome.org/show_bug.cgi?id=751401 gtk/gtkdnd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit 4b31962475b349fcc5c0445f7f3f14ea16889505 Author: Pedro Albuquerque Date: Tue Jul 7 05:25:12 2015 +0000 Updated Portuguese translation po/pt.po | 247 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 127 insertions(+), 120 deletions(-) commit 826c1db859ce1c33e34ec723dd7d72313a97a67d Author: Matthias Clasen Date: Tue Jul 7 00:24:19 2015 -0400 file chooser: Add a shortcut to focus the sidebar Alt+P used to do this in the gtk2 filechooser (well, sometimes). Add this back as a key binding. https://bugzilla.gnome.org/show_bug.cgi?id=720684 gtk/gtkfilechooserwidget.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) commit fb316156e24b1021c8680b05392be972645515fd Author: Matthias Clasen Date: Mon Jul 6 23:21:51 2015 -0400 place sidebar: Make removing bookmarks work again This was accidentally broken in ae8c07c67cfa83d967 when I forgot to switch the sense of a condition. gtk/gtkplacessidebar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e1211577b343da3d8c1d195275a7d2d780fe011a Author: Matthias Clasen Date: Mon Jul 6 23:03:56 2015 -0400 file chooser: Make delete confirmation match nautilus No need to diverge here. gtk/gtkfilechooserwidget.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit b96b796a8d8497da995e29d4f4c5e3b5b3c1d53a Author: Matthias Clasen Date: Mon Jul 6 22:57:40 2015 -0400 file chooser: Separate out delete and trash We only ever show one of the two context menu items (and we prefer Move to Trash over Delete). Only use the confirmation dialog when deleting. gtk/gtkfilechooserwidget.c | 92 +++++++++++++++++++++++++++++++++++---------- gtk/gtksearchenginesimple.c | 1 + 2 files changed, 73 insertions(+), 20 deletions(-) commit 3cbe6d86aff9a58431c529d40f0a932ce575c4c2 Author: Matthias Clasen Date: Mon Jul 6 21:59:10 2015 -0400 place sidebar: minor change We generally prefer for loops to iterate over lists. gtk/gtkplacessidebar.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) commit 06f91028408205fa55ef24c5553d058f5feba3e3 Author: Matthias Clasen Date: Mon Jul 6 21:39:39 2015 -0400 file chooser: Allow rename-to-self When checking for a name clash for renaming, don't complain if the name is unchanged. That's harmless. gtk/gtkfilechooserwidget.c | 8 ++++++++ 1 file changed, 8 insertions(+) commit 7c9e3df1987617de56b594d6674bd60cfc7db477 Author: Matthias Clasen Date: Mon Jul 6 21:35:03 2015 -0400 wip: reshuffle name checks gtk/gtkfilechooserwidget.c | 65 +++++++++++++++++++++------------------------- 1 file changed, 30 insertions(+), 35 deletions(-) commit 88cee9288bae355325fdf148cb22ab8b7ffe82a9 Author: Matthias Clasen Date: Mon Jul 6 20:57:11 2015 -0400 file chooser: Remove unused field gtk/gtkfilechooserwidget.c | 1 - 1 file changed, 1 deletion(-) commit 56af2358deeacff9f25faaf897adaf53c76adac0 Author: Matthias Clasen Date: Mon Jul 6 20:50:08 2015 -0400 file chooser: Clear search entry when it goes away Keeping the entry contents conflicts with type-to-search. gtk/gtkfilechooserwidget.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit 1eb1481bdf998383bf3fc58886aff50e2e164d54 Author: Paolo Borelli Date: Mon Jul 6 20:03:54 2015 +0200 css: support text-decoration-style The support is limited to underline single, double and wavy, which is what pango has today. gtk/gtkcssenumvalue.c | 54 +++++++++++++++++++++++++++++++++++++-- gtk/gtkcssenumvalueprivate.h | 4 +++ gtk/gtkcssshorthandpropertyimpl.c | 12 ++++++--- gtk/gtkcssstylepropertyimpl.c | 22 ++++++++++++++++ gtk/gtkcsstypesprivate.h | 7 +++++ gtk/gtkstylecontext.c | 25 +++++++++++++++--- 6 files changed, 116 insertions(+), 8 deletions(-) commit 09273d91f3a8b2e8bcbbaf5f8f81e91ff7ca1ea6 Author: Michael Catanzaro Date: Mon Jul 6 11:21:41 2015 -0500 wayland: print correct coordinates during DnD Convert wl_fixed values to floats for printing, rather than printing them as non-meaningful integers. https://bugzilla.gnome.org/show_bug.cgi?id=752025 gdk/wayland/gdkdevice-wayland.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) commit 3f8982a0cd7b779fe023bbd19ec4cebf5baae422 Author: Carlos Garnacho Date: Wed Jul 1 18:46:30 2015 +0200 gtkdnd: Traverse across insensitive widgets The current widget lookup code bails out on insensitive widgets, there's however legit cases where we want DnD handled by a parent of the insensitive widget, so just keep going upwards in that case. We also use now the widget state flags, because get_sensitive() doesn't propagate across hierarchies, so we could conceivably find a drop site inside an insensitive widget. https://bugzilla.gnome.org/show_bug.cgi?id=751793 gtk/gtkdnd.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) commit 7f57f63ebaa8e3d12bdaef0ebc730cd81c9bb2fe Author: Carlos Garnacho Date: Mon Jul 6 16:39:06 2015 +0200 gtkwindow: Only allow unrestricted positioning to text handle popovers This behavior has been made optional on add_popover() time, text handles will keep being able to overflow the window, in order to allow text selection on views too close to the window edge. Regular GtkPopovers are reinstaurated to the previous size positioning logic though, that is, limited by the visible area of the window. gtk/gtkpopover.c | 4 ++-- gtk/gtktexthandle.c | 2 +- gtk/gtkwindow.c | 36 +++++++++++++++++++++++++++++++----- gtk/gtkwindowprivate.h | 3 ++- 4 files changed, 36 insertions(+), 9 deletions(-) commit dec95caf942dba64110b910ffbfc4ce9d3058561 Author: Carlos Garnacho Date: Wed Jul 1 22:24:03 2015 +0200 scrolledwindow: Keep scrollbars out of GtkScrollable::get_border It looks a bit odd that scrollbars stay over treeview headers and similar, seems nicer to just avoid the border regions. https://bugzilla.gnome.org/show_bug.cgi?id=751805 gtk/gtkscrolledwindow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4cbab1180c4599c87d596a43b3c67803c8aee8de Author: Benjamin Otte Date: Mon Jul 6 04:35:59 2015 +0200 cssmatcher: Make nth-child(odd) work on first line .. instead of only on 3rd, 5th, 7th, ... gtk/gtkcssmatcher.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 8d3737e4e376bc6dcd4d581cbd34aa2ae3396c59 Author: Benjamin Otte Date: Mon Jul 6 04:29:09 2015 +0200 cssnode: Do finer-grained position invalidation As a side effect, this should fix this bug: https://bugzilla.gnome.org/show_bug.cgi?id=751910 gtk/gtkcssnode.c | 31 ++++++++++++++++++++++++++----- 1 file changed, 26 insertions(+), 5 deletions(-) commit df7113812bbccc4ad862e1c931c8ba2c94d91c4a Author: Benjamin Otte Date: Mon Jul 6 03:58:56 2015 +0200 csstypes: Change NTH_CHILD and NTH_LAST_CHILD change propagation For now assume that if those flags change for a node, they also changed for all sibling nodes. This is not strictly true but simplifies invalidation. The reason it simplifies invalidation is that when removing or adding a node, we can just invalidate the first node (for NTH_LAST_CHILD) and the new node (for NTH_CHILD) and all the other nodes will be invalidated automatically. gtk/gtkcsstypes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 69e396ea0ab6e25ebeb87ee55ea11d3a5c376f44 Author: Benjamin Otte Date: Mon Jul 6 00:21:03 2015 +0200 cssselector: Report finer granularity for position changes gtk/gtkcssselector.c | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) commit 6323010e2e5f1103a7e89248b28a0b75a8b7fd71 Author: Benjamin Otte Date: Sun Jul 5 22:45:34 2015 +0200 csstypes: expand GtkCssChange enum Instead of GTK_CSS_CHANGE_POSITION we now have 4 values: GTK_CSS_CHANGE_FIRST_CHILD, GTK_CSS_CHANGE_LAST_CHILD, GTK_CSS_CHANGE_NTH_CHILD and GTK_CSS_CHANGE_NTH_LAST_CHILD Nobody is using them directly yet. gtk/gtkcsstypes.c | 15 ++++++++-- gtk/gtkcsstypesprivate.h | 75 ++++++++++++++++++++++++++++++++---------------- 2 files changed, 63 insertions(+), 27 deletions(-) commit abc47d7faaf0fbea0389d84f199cd7ed0613872a Author: Jasper St. Pierre Date: Sun Jul 5 15:45:49 2015 -0700 gdkdisplay-x11: The leader window should be an input-only window This prevents it from creating a _NET_WM_USER_TIME_WINDOW, which can confuse mutter / other window managers, and also me, when debugging. gdk/x11/gdkdisplay-x11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 803430a779c284fa038fcc45f00c188ed504e826 Author: Paolo Borelli Date: Mon Jul 6 00:20:08 2015 +0200 pango: make merge_attrs return the merged list This simplifies all the callers gtk/gtkentry.c | 12 ++++-------- gtk/gtklabel.c | 29 +++++------------------------ gtk/gtkpango.c | 18 ++++++++++++++---- gtk/gtkpango.h | 4 ++-- 4 files changed, 25 insertions(+), 38 deletions(-) commit 180a378a073d24339dbec53874cf53e082cbb831 Author: Paolo Borelli Date: Sun Jul 5 23:24:49 2015 +0200 css: add shorthand text-decoration property Note that for now we take into account only text-decoration-line and text-decoration-color gtk/gtkcssshorthandpropertyimpl.c | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) commit a57e6731c4141d97afd8fa36b9e6b5587fbb8412 Author: Paolo Borelli Date: Sun Jul 5 22:05:33 2015 +0200 css: support text-decoration-color gtk/gtkcssstylepropertyimpl.c | 10 ++++++++++ gtk/gtkcsstypesprivate.h | 1 + gtk/gtkstylecontext.c | 12 ++++++++++++ 3 files changed, 23 insertions(+) commit 77658b76aeffa74c972b9a8a5439cd6b2f11b2bb Author: Paolo Borelli Date: Sun Jul 5 19:31:28 2015 +0200 linkbutton: use the text-decoration-line css Remove the custom add() implementation and use css to underline the label. gtk/gtklinkbutton.c | 39 ++------------------------------ gtk/theme/Adwaita/_common.scss | 3 +++ gtk/theme/Adwaita/gtk-contained-dark.css | 2 ++ gtk/theme/Adwaita/gtk-contained.css | 2 ++ 4 files changed, 9 insertions(+), 37 deletions(-) commit 384df61c90a25e813fa3441f35b572e890175080 Author: Paolo Borelli Date: Sun Jul 5 18:59:27 2015 +0200 css: add support for text-decoration-line gtk/gtkcssenumvalue.c | 46 +++++++++++++++++++++++++++++++++++++++++++ gtk/gtkcssenumvalueprivate.h | 4 ++++ gtk/gtkcssstylepropertyimpl.c | 22 +++++++++++++++++++++ gtk/gtkcsstypesprivate.h | 7 +++++++ gtk/gtkstylecontext.c | 38 ++++++++++++++++++++++++++++------- 5 files changed, 110 insertions(+), 7 deletions(-) commit 9e26fa9a42d0cb9ae55f630497d2a0a051da7d55 Author: Paolo Borelli Date: Sun Jul 5 10:48:40 2015 +0200 entry: add css letter-spacing gtk/gtkentry.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) commit a19331f2313ba47ce15c06f3d8485e68474baa4e Author: Paolo Borelli Date: Sat Jul 4 19:56:40 2015 +0200 label: add support for CSS letter-spacing property Support letter-spacing CSS property on GtkLabel. Reftest is included. gtk/gtkcssstylepropertyimpl.c | 17 +++++++++++++++++ gtk/gtkcsstypesprivate.h | 11 +++++++---- gtk/gtklabel.c | 25 ++++++++++++++++++++++++- gtk/gtkstylecontext.c | 20 ++++++++++++++++++++ gtk/gtkstylecontextprivate.h | 2 ++ testsuite/reftests/Makefile.am | 4 ++++ testsuite/reftests/letter-spacing.c | 30 ++++++++++++++++++++++++++++++ testsuite/reftests/letter-spacing.css | 3 +++ testsuite/reftests/letter-spacing.ref.ui | 17 +++++++++++++++++ testsuite/reftests/letter-spacing.ui | 16 ++++++++++++++++ 10 files changed, 140 insertions(+), 5 deletions(-) commit b92c530a61420fc039048aff4feb3f019dc7cdfe Author: Paolo Borelli Date: Sun Jul 5 22:48:16 2015 +0200 pango: move an utility function from gtklabel This will be used both by gtklabel and gtkentry gtk/gtklabel.c | 19 ++----------------- gtk/gtkpango.c | 22 ++++++++++++++++++++++ gtk/gtkpango.h | 3 +++ 3 files changed, 27 insertions(+), 17 deletions(-) commit 3175d0fcf0c1da7d5b0d7307772b991222d08a33 Author: Dimitris Spingos Date: Mon Jul 6 02:28:20 2015 +0300 Updated Greek translation po-properties/el.po | 1275 ++++++++++++++++++++++++++------------------------- po/el.po | 729 ++++++++++++++++++----------- 2 files changed, 1110 insertions(+), 894 deletions(-) commit 5436c74a198aa929656230d86b20383a17f81f77 Author: Ting-Wei Lan Date: Mon Jul 6 03:26:48 2015 +0800 Fix return value error in _gtk_file_system_model_get_directory gtk/gtkfilesystemmodel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c222d59f53080d14c4f17a97e50d43fe13b63d37 Author: Pedro Albuquerque Date: Sun Jul 5 10:02:44 2015 +0000 Updated Portuguese translation po/pt.po | 215 ++++++++++++++++++++++++++++++++++++++------------------------- 1 file changed, 130 insertions(+), 85 deletions(-) commit 39822092f4b04a0ac6dc8147d6e567535aac3596 Author: Matthias Clasen Date: Sat Jul 4 23:46:11 2015 -0400 file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150 gtk/gtkfilechooserwidget.c | 116 +++++++++++++++++++++++++++++++++++++++++++- gtk/gtksearchenginesimple.c | 3 +- 2 files changed, 117 insertions(+), 2 deletions(-) commit 15617a69aa74cd9c3080adcd5204cfdf288980c0 Author: Matthias Clasen Date: Sat Jul 4 21:16:55 2015 -0400 file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150 gtk/gtkfilechooserwidget.c | 211 ++++++++++++++++++++++++++++++++++++----- gtk/gtksearchenginesimple.c | 3 +- gtk/ui/gtkfilechooserwidget.ui | 66 +++++++++++++ 3 files changed, 253 insertions(+), 27 deletions(-) commit 530d295a2eda444b6585880532c54797d00d6230 Author: Matthias Clasen Date: Sat Jul 4 20:30:47 2015 -0400 Fix up some whitespace mishap gtk/gtkfilechooserwidget.c | 40 ++++++++++++++++------------------------ 1 file changed, 16 insertions(+), 24 deletions(-) commit 8379ef30675f9cd33298237eb14dad729bef17cd Author: Matthias Clasen Date: Sat Jul 4 20:12:00 2015 -0400 file chooser: Redo the trailing space warning Redo this slightly differently, so we can keep all the simple checks in one place. This will make it easier to reuse the code for file renaming. gtk/gtkfilechooserwidget.c | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-) commit 8b90c79037be95cb9a5c93c8e5145e9da0cd316e Author: Matthias Clasen Date: Sat Jul 4 22:32:06 2015 -0400 places sidebar: Fix memory handling of rename popover We were freeing the same string twice here, leading to badness. gtk/gtkplacessidebar.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) commit 94bcdd32174bd10d97ba7b909b6a8a250bbab9f7 Author: Arc Riley Date: Wed Jul 1 16:23:15 2015 -0700 Strip leading and trailing whitespace from filechooser save filenames This makes a local copy of the file part of the entry to strip it transparently Since this is assumed to be a mistake, the user is not notified. https://bugzilla.gnome.org/show_bug.cgi?id=593372 gtk/gtkfilechooserwidget.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) commit 02b5ac9ee487322ff458b21837582f6e257077a4 Author: Arc Riley Date: Wed Jul 1 14:33:07 2015 -0700 Warn for whitespace at beginning or end of new folder names The warning is not intended to disable the Create button and must only be shown when the folder is not found, so this is implemented in the folder name exists callback. A "name" entry was added to FileExistsData to pass the filename to the callback https://bugzilla.gnome.org/show_bug.cgi?id=751800 gtk/gtkfilechooserwidget.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) commit d2569a3860613172007630ad863162d39fbb7cdc Author: Emmanuele Bassi Date: Sat Jul 4 19:33:23 2015 +0100 docs: Drop deprecated symbolic icon names Do not suggest using icons that do not exist. gtk/deprecated/gtkarrow.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit c5a250ce379357ff3cccd8b5352af36c21fe7465 Author: Emmanuele Bassi Date: Sat Jul 4 19:30:22 2015 +0100 container: Update the add() warning Now that gtk_widget_reparent() has been deprecated, we should not suggest it. gtk/gtkcontainer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bea3cbaba5d6d061a321194e5d34dc335102aea9 Author: Pedro Albuquerque Date: Sat Jul 4 07:54:42 2015 +0000 Updated Portuguese translation po/pt.po | 865 +++++++++++++++++++++++++++++---------------------------------- 1 file changed, 399 insertions(+), 466 deletions(-) commit 6c8f7aae4f4887568ffa85428825769bd7afebab Author: Pedro Albuquerque Date: Sat Jul 4 07:47:04 2015 +0000 Updated Portuguese translation po-properties/pt.po | 1799 +++++++++++++++++++++++++-------------------------- 1 file changed, 890 insertions(+), 909 deletions(-) commit 309c845e69e0245074dfa7acccffa73a1d68c6bc Author: Matthias Clasen Date: Sat Jul 4 00:13:13 2015 -0400 file chooser: Make Ctrl-L work in search mode There is no real reason to not allow this. The transition is not quite as smooth as it should be, currently, but at least it works. gtk/gtkfilechooserwidget.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) commit a45321259176d7ccf4decc96226abd25a29fea67 Author: Matthias Clasen Date: Sat Jul 4 00:02:55 2015 -0400 file chooser dialog: Make button not take focus Things work smoother, keynav-wise, if the search button does not take focus on click. gtk/gtkfilechooserdialog.c | 1 + 1 file changed, 1 insertion(+) commit 4dafcf9c8b5eee57b2f698e32d3e62bf92be9796 Author: Matthias Clasen Date: Fri Jul 3 22:45:58 2015 -0400 file chooser: Make unsetting save entry work Fix an overzealous assertion. gtk/gtkfilechooserwidget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 017025c1a7fc37f442b1556de7573ea6eeb35e2a Author: Matthias Clasen Date: Fri Jul 3 22:45:15 2015 -0400 file chooser dialog: Make action changes work We were not listening for action changes to update the save entry. gtk/gtkfilechooserdialog.c | 156 ++++++++++++++++++++++++--------------------- 1 file changed, 82 insertions(+), 74 deletions(-) commit bb6f698abef70f69e01545b130b38048cb474f9e Author: Matthias Clasen Date: Fri Jul 3 20:53:54 2015 -0400 file chooser: Cleanups gtk/gtkfilechooserwidget.c | 2104 ++++++++++++++++++++++---------------------- 1 file changed, 1029 insertions(+), 1075 deletions(-) commit 4a21c129e4d4583d6478a2e0f8bf0597dac0dc8a Author: Matthias Clasen Date: Fri Jul 3 09:51:38 2015 -0700 testfilechooser: Add a --local-only flag This allows for easier testing of !local-only mode. tests/testfilechooser.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 29abbdd3e3aa59cd1f3986eabbfeafa19aaa4195 Author: Matthias Clasen Date: Fri Jul 3 09:51:03 2015 -0700 file chooser: Don't show Trash in save mode You can't save there... gtk/gtkfilechooserwidget.c | 1 + 1 file changed, 1 insertion(+) commit 78db92df7e2e33a081094a52e3c96d572670114e Author: Matthias Clasen Date: Fri Jul 3 09:49:00 2015 -0700 GtkPlacesSidebar: Allow hiding Trash We will use this in the filechooser in save mode. docs/reference/gtk/gtk3-sections.txt | 2 ++ gtk/gtkplacessidebar.c | 62 +++++++++++++++++++++++++++++++++++- gtk/gtkplacessidebar.h | 5 +++ 3 files changed, 68 insertions(+), 1 deletion(-) commit fa3ff773be72e1585e30354248749d7172275806 Author: Matthias Clasen Date: Fri Jul 3 09:24:23 2015 -0700 GtkTreeViewColumn: Fix a documentation typo gtk/gtktreeviewcolumn.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 22294a4a0d9edd101dd9d1f9df92b54362454d71 Author: Matthias Clasen Date: Fri Jul 3 09:22:39 2015 -0700 file chooser: Improve column sizing Allow the name and location columns to be resized, but arrange for their sizing to be reset when the column layout changes (either by the location column appearing/disappearing, or by the time column changing between mtime and atime. This gives a decent compromise between good automatic sizing and user control. gtk/gtkfilechooserwidget.c | 44 +++++++++++++++++++++++++++++++----------- gtk/ui/gtkfilechooserwidget.ui | 32 ++++++++++++++---------------- 2 files changed, 47 insertions(+), 29 deletions(-) commit ed1c349e0b914621a5fc25c6add92a6c8bc2c0b4 Author: Matthias Clasen Date: Fri Jul 3 07:52:39 2015 -0700 file chooser: Remove a wrong assumption The code for getting the selected files was assuming that we are always in browse mode, and was causing warnings when hitting Ctrl-L twice, right after opening the file chooser. The fix is to simple use the model that is passed into the callback. gtk/gtkfilechooserwidget.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) commit 17a860cea23cefdd4b1ec7dbe9b2a8f25fd77c08 Author: Matthias Clasen Date: Fri Jul 3 07:47:50 2015 -0700 file chooser: Don't show Enter Location in sidebar Following the file chooser mockups. gtk/gtkfilechooserwidget.c | 11 ----------- gtk/ui/gtkfilechooserwidget.ui | 2 -- 2 files changed, 13 deletions(-) commit c7bc90209322576732d4b51478874962d407a46f Author: Matthias Clasen Date: Thu Jul 2 23:16:19 2015 -0700 file chooser: Update empty state for search Follow the mockups more. gtk/ui/gtkfilechooserwidget.ui | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) commit 191bccebf3c24fafa90389f40380fedec3242318 Author: Matthias Clasen Date: Thu Jul 2 23:08:59 2015 -0700 file chooser: Add search progress Show a spinner if no search reasults have shown up yet and the search is still going, after 2 seconds. gtk/gtkfilechooserwidget.c | 43 +++++++++++++++++++++++++++++++++++++++++- gtk/ui/gtkfilechooserwidget.ui | 9 +++++++++ 2 files changed, 51 insertions(+), 1 deletion(-) commit 31a022175f9ba67d0a69f41ca29ac627919cb469 Author: Matthias Clasen Date: Thu Jul 2 22:35:49 2015 -0700 file chooser: Set fixed sort functions for recent and search gtk/gtkfilechooserwidget.c | 226 ++++++++++++++++++++++++++++++--------------- 1 file changed, 150 insertions(+), 76 deletions(-) commit 0ac17418dd27390be35ac19c8dbbffc1424a6227 Author: Matthias Clasen Date: Thu Jul 2 22:19:05 2015 -0700 file chooser: Improve location column formatting gtk/gtkfilechooserwidget.c | 55 +++++----------------------------------------- 1 file changed, 6 insertions(+), 49 deletions(-) commit 39c2d12330b6d4405ca8a5599c12017c58626fcf Author: Matthias Clasen Date: Thu Jul 2 16:12:55 2015 -0700 file chooser: Improve the mode switching operation Avoid reloading models unnecessarily, e.g. when the user switches to search and back without starting a search. Keep the current list contents visible until a search is actually started. Also, synchronize any changes in the column layout with the corresponding model changes. gtk/gtkfilechooserwidget.c | 70 ++++++++++++++++++++++------------------------ 1 file changed, 34 insertions(+), 36 deletions(-) commit 9a444673186c2d9be1f2c97d85d6f658c2338417 Author: Matthias Clasen Date: Thu Jul 2 16:12:22 2015 -0700 Add a getter for the directory to file system model This will allow us to aovid reloading if the directory is unchanged. gtk/gtkfilesystemmodel.c | 9 +++++++++ gtk/gtkfilesystemmodel.h | 1 + 2 files changed, 10 insertions(+) commit 5763199e43253f99d9859a46d23136879c773b8e Author: Matthias Clasen Date: Thu Jul 2 14:47:30 2015 -0700 file chooser: Clean up enum handling Use g_settings_get_set_enum to handle the clock and date format settings. gtk/gtkfilechooserprivate.h | 20 ++++++++++--------- gtk/gtkfilechooserwidget.c | 47 ++++++++++++++++++++++++--------------------- 2 files changed, 36 insertions(+), 31 deletions(-) commit f690167b0d4d8722b1f3e94827992477b05f0064 Author: Matthias Clasen Date: Thu Jul 2 14:36:00 2015 -0700 file chooser: Code cleanups Shorten excessively long field names. gtk/gtkfilechooserwidget.c | 90 +++++++++++++++++++++++----------------------- 1 file changed, 45 insertions(+), 45 deletions(-) commit 443601addc6e031e54c04f4c3233fe86d1ff480c Author: Matthias Clasen Date: Thu Jul 2 14:31:29 2015 -0700 file chooser: Consistently clear model caches This was not done for all models in all places, leading to e.g. icon theme updates not applying correctly to search results. gtk/gtkfilechooserwidget.c | 78 +++++++++++++++++++++++++++------------------- 1 file changed, 46 insertions(+), 32 deletions(-) commit 2cd6d1a351b2b77e257a9597db9e48d516c6a9fa Author: Matthias Clasen Date: Thu Jul 2 10:44:19 2015 -0700 file chooser: Add a way to toggle time display gtk/gtkfilechooserwidget.c | 117 ++++++++++++++++++++++++++++++--------------- 1 file changed, 79 insertions(+), 38 deletions(-) commit 215a9a1b08f99e3b8313c2c33795f11158aba3ec Author: Matthias Clasen Date: Thu Jul 2 08:32:39 2015 -0700 file chooser: remove a stale comment gtk/gtkfilechooserwidget.c | 5 ----- 1 file changed, 5 deletions(-) commit 8974ec74131565e13fa736b27a13100d719ef670 Author: Matthias Clasen Date: Thu Jul 2 02:37:59 2015 -0700 file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned. gtk/gtkfilechooserwidget.c | 115 +++++++++++++++++++++++---- gtk/org.gtk.Settings.FileChooser.gschema.xml | 12 +++ gtk/ui/gtkfilechooserwidget.ui | 25 +++++- 3 files changed, 134 insertions(+), 18 deletions(-) commit 1c82a533ede33f2eceeccc99b913e3d575c503e2 Author: Matthias Clasen Date: Thu Jul 2 02:10:05 2015 -0700 file chooser: Don't allow resorting recent files They are inherently sorted by access time. gtk/gtkfilechooserwidget.c | 35 ++++++++++++++--------------------- 1 file changed, 14 insertions(+), 21 deletions(-) commit 412e33da168a07e903aa13386bd602fa3379ccc0 Author: Matthias Clasen Date: Wed Jul 1 14:04:17 2015 -0700 file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime. gtk/gtkfilechooserwidget.c | 150 ++++++++++++++++++----------------------- gtk/gtksearchenginesimple.c | 3 +- gtk/ui/gtkfilechooserwidget.ui | 14 ++-- 3 files changed, 75 insertions(+), 92 deletions(-) commit 33b5c26f419aab0c072a7ac49f450e861459b852 Author: Matthias Clasen Date: Wed Jul 1 12:51:20 2015 -0700 file chooser: Add and use a model search engine This search engine reuses the GFileInfo that is already loaded for the file list, to ensure that hits from the current directory always appear promptly. gtk/Makefile.am | 2 + gtk/gtkfilechooserwidget.c | 13 ++- gtk/gtksearchengine.c | 57 +++++++++++++- gtk/gtksearchengine.h | 4 + gtk/gtksearchenginemodel.c | 191 +++++++++++++++++++++++++++++++++++++++++++++ gtk/gtksearchenginemodel.h | 44 +++++++++++ 6 files changed, 306 insertions(+), 5 deletions(-) commit f87f43b6229d2314523c925d0f3584ab23c7adf9 Author: Matthias Clasen Date: Thu Jul 2 16:23:48 2015 -0700 testfilechooser: Disable the terrible preview It makes testing the intended user experience harder. tests/testfilechooser.c | 2 ++ 1 file changed, 2 insertions(+) commit fe128b5b4d198a39c74a1a81b7a3e27f12262ff8 Author: Matthias Clasen Date: Wed Jul 1 08:40:15 2015 -0700 file chooser: Don't show recent in save mode Don't show Recent in the sidebar when we are in save mode. We also ignore the startup-mode = recent in save mode now - we don't want to populate the file list with recent files if Recent is not on the sidebar. If you really want to go there, you can still enter recent:// in the location entry. https://bugzilla.gnome.org/show_bug.cgi?id=751653 gtk/gtkfilechooserwidget.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 648e4a7ea928d0d6d183e7e94def0ae15f97ac7b Author: Matthias Clasen Date: Mon Jun 29 08:40:14 2015 -0700 file chooser: Add Ctrl-F as search shortcut This is what nautilus uses, and is more discoverable than the somewhat easter-egg Alt-S, which is still supported. gtk/gtkfilechooserwidget.c | 4 ++++ 1 file changed, 4 insertions(+) commit 5bc88bdc676e85b5ecc022fb486da779f1c068b9 Author: Matthias Clasen Date: Mon Jun 29 08:39:22 2015 -0700 file chooser: Make search shortcut toggle This is more in line with having a toggle button for search, and it matches what we do e.g. in nautilus. gtk/gtkfilechooserwidget.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) commit 75411efa48474f6b9c5eaa14740b0ad9032f5211 Author: Matthias Clasen Date: Sat Jun 27 15:54:49 2015 -0400 file chooser: Tweak bindings in save mode In save modes, the entry is really more for entering a name than entering a full location, so don't go there eagerly when '.', '/' or '~' are pressed. Make Ctrl-L work better in this mode too. gtk/gtkfilechooserwidget.c | 44 ++++++++++++++++++++------------------------ 1 file changed, 20 insertions(+), 24 deletions(-) commit 1c3ccb39c7aded5bc14d6fb7ab566411f90fe7d1 Author: Matthias Clasen Date: Sat Jun 27 15:23:24 2015 -0400 file chooser: Trigger location entry not just from file list Use the same code that brings up the location entry on '/', '~' or '.' also when the focus is not on the file list. This prevents those key presses on the sidebar from ending up in the search entry. gtk/gtkfilechooserwidget.c | 35 ++++++++++++++++++++++++++--------- 1 file changed, 26 insertions(+), 9 deletions(-) commit 5825965027b978a0efda6741f765799c7c16c5b5 Author: Matthias Clasen Date: Sat Jun 27 15:06:25 2015 -0400 file chooser: Open location entry on '.' Typing ./ is a fairly common practice to enter a location relative to the cwd, so make this open the location entry. gtk/gtkfilechooserwidget.c | 1 + 1 file changed, 1 insertion(+) commit a3470521ae2474e31dd244f4b76ba4db84aad9dc Author: Matthias Clasen Date: Sat Jun 27 13:44:58 2015 -0400 Revert "file chooser: Open location entry more easily" This reverts commit e6c1cbc88ebbf51dcf4ca2b4b0016c81808d7889. gtk/gtkfilechooserwidget.c | 1 - 1 file changed, 1 deletion(-) commit c0afb891c8ffeb90e67e8f947a7e7b9b3fff62ee Author: Matthias Clasen Date: Sat Jun 27 13:44:26 2015 -0400 Revert "file chooser: Don't start search too eagerly" This reverts commit f126157bfa9e8a550067fa169de24697add028bb. gtk/gtkfilechooserwidget.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) commit 1883c5fb28409dc3726e6586d38df4b12c88304c Author: Matthias Clasen Date: Sat Jun 27 12:23:48 2015 -0400 file chooser: Improve keynav Some internal containers were erroneously taking focus, interrupting the flow of tab keynav, and using arrow keynav to go from the file list to the sidebar did not work anymore, after the recent sidebar rewrite. gtk/gtkfilechooserwidget.c | 4 ++-- gtk/ui/gtkfilechooserwidget.ui | 8 +------- 2 files changed, 3 insertions(+), 9 deletions(-) commit 710d193f91a33cda3229220358044fe6ec4ddbd4 Author: Matthias Clasen Date: Sat Jun 27 12:05:04 2015 -0400 file chooser: Give the location column more space Giving it 15 characters makes it at least fit "Documents" without ellipsizing. gtk/gtkfilechooserwidget.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 356f507059b4bc675262d8834616b5cd0be1de76 Author: Matthias Clasen Date: Sat Jun 27 02:22:23 2015 -0400 file chooser: Sort search results better Set a default sort function that sorts results from the current folder first. gtk/gtkfilechooserwidget.c | 79 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 78 insertions(+), 1 deletion(-) commit 9b5e00b3c418d5d6dd0bd193aa974e375669025c Author: Matthias Clasen Date: Sat Jun 27 01:40:04 2015 -0400 file chooser entry: Capture Escape and emit :hide-entry Make the file chooser entry optionally capture Escape and emit a signal. Make the file chooser widget hide the entry on that signal and go back to the path bar. This gives us a two-level undo: location entry -> path bar -> dialog close. When the location entry is permanently displayed in the header for save mode, we still let the first Escape close the dialog. gtk/gtkfilechooserdialog.c | 2 +- gtk/gtkfilechooserentry.c | 31 ++++++++++++++++++++++++++++++- gtk/gtkfilechooserentry.h | 3 ++- gtk/gtkfilechooserwidget.c | 10 +++++++++- 4 files changed, 42 insertions(+), 4 deletions(-) commit e0b81faadee8e1d1d9092e3ef47c4beb7f5a341d Author: Matthias Clasen Date: Sat Jun 27 01:23:16 2015 -0400 file chooser: Make Escape work in search entry Arrange things so that hitting Escape during a running search stops the search, but leaves the search results around, and hitting Escape again leaves the search mode. gtk/gtkfilechooserwidget.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 0f9b87cfeb77e9fb9b9d3511dcf8c6bf6ea86e4e Author: Matthias Clasen Date: Sat Jun 27 01:07:32 2015 -0400 file chooser: Make location column work better The location column did not work for search results in recent://. Fix that by looking at the target uri in this case. Show the location column in recent mode. And make it more similar to nautilus by showing the full path if it is not below $HOME. gtk/gtkfilechooserwidget.c | 24 +++++++++++++++++++----- gtk/gtksearchenginesimple.c | 1 + 2 files changed, 20 insertions(+), 5 deletions(-) commit f968199b02e0761b21e763f0a51121e71d9c277f Author: Matthias Clasen Date: Sat Jun 27 00:21:53 2015 -0400 file chooser: Make search in recent work All that was needed here was to set the query location. gtk/gtkfilechooserwidget.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit 0b11d8c115ef5b9cd48b2ea9f49513164d93b628 Author: Matthias Clasen Date: Sat Jun 27 00:08:57 2015 -0400 file chooser dialog: Put save entry into header When we have a header bar, put a save entry there and make the file chooser use it. gtk/gtkfilechooserdialog.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) commit 4f3f61bf5ffe3c57dcbb21e87902816687067827 Author: Matthias Clasen Date: Sat Jun 27 00:07:59 2015 -0400 file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one. gtk/Makefile.am | 1 + gtk/gtkfilechooserwidget.c | 79 ++++++++++++++++++++++++++++++++++----- gtk/gtkfilechooserwidgetprivate.h | 35 +++++++++++++++++ 3 files changed, 105 insertions(+), 10 deletions(-) commit 140a157d474c282249ca8c418dbfb134a9f9743c Author: Matthias Clasen Date: Fri Jun 26 22:13:33 2015 -0400 file chooser: Update sidsebar when entry goes away gtk/gtkfilechooserwidget.c | 2 ++ 1 file changed, 2 insertions(+) commit 6516437353b5e86009e29f1b591057c7f4f39cd0 Author: Matthias Clasen Date: Fri Jun 26 21:50:00 2015 -0400 file chooser: Use icon for create folder button This follows the latest mockups. gtk/ui/gtkfilechooserwidget.ui | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) commit e9e4ed5f7f1798787ba06e8a509821a955b10556 Author: Matthias Clasen Date: Fri Jun 26 21:15:55 2015 -0400 file chooser dialog: Show a subtitle Use the new "subtitle" property of the file chooser widget to display a subtitle in the headerbar, if we have one. gtk/gtkfilechooserdialog.c | 3 +++ 1 file changed, 3 insertions(+) commit 10f5076bb55e64cd07ea4b7783d60e37c727a31a Author: Matthias Clasen Date: Fri Jun 26 21:14:37 2015 -0400 file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode. gtk/gtkfilechooserwidget.c | 66 +++++++++++++++++++++++++++++++++++++++------- 1 file changed, 57 insertions(+), 9 deletions(-) commit 715aba650e50fe95562fcd66789554304c3f1a8d Author: Matthias Clasen Date: Fri Jun 26 21:13:00 2015 -0400 places sidebar: Add private api to get title The places sidebar already does all the work to determine the right label to use for the current location of the filechooser. We want to use the same label in the headerbar subtitle, so add some private API to get it. gtk/gtkplacessidebar.c | 17 +++++++++++++++++ gtk/gtkplacessidebarprivate.h | 3 +++ 2 files changed, 20 insertions(+) commit 7e45b09c8e74cc0685556df102874a9c642fda11 Author: Matthias Clasen Date: Fri Jun 26 20:02:31 2015 -0400 file chooser: More search rework Drop the radio buttons for current location vs everywhere, and always search in the current location. gtk/gtkfilechooserwidget.c | 12 +----------- gtk/ui/gtkfilechooserwidget.ui | 28 ++-------------------------- 2 files changed, 3 insertions(+), 37 deletions(-) commit 1f96f351e09d6f6fccb62243926c364cad0417c0 Author: Georges Basile Stavracas Neto Date: Fri Jul 3 15:48:48 2015 -0300 entrycompletion: no need to return boolean The boolean _gtk_entry_completion_resize_popup's return value is not used anywhere, and only adds more complexity for the method. https://bugzilla.gnome.org/show_bug.cgi?id=751913 gtk/gtkentrycompletion.c | 8 +++----- gtk/gtkentryprivate.h | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) commit 1e6c7e3af09c5ec0aed5297fc285d13cff76e720 Author: William Hua Date: Fri Jul 3 12:11:19 2015 -0400 mir: fix mir pointer event to gdk translation gdk/mir/gdkmireventsource.c | 56 ++++++++++++++++++--------------------------- 1 file changed, 22 insertions(+), 34 deletions(-) commit 2d223facdc0bf7ed0342da3b40d6ddb658cd3cb4 Author: William Hua Date: Thu Jul 2 16:38:57 2015 -0400 mir: ensure parent surface before creating child surface gdk/mir/gdkmirwindowimpl.c | 32 ++++++++++++++++++++++++-------- 1 file changed, 24 insertions(+), 8 deletions(-) commit c806f9b7090d5fb63e7db2067baa012b1da460c8 Author: Olivier Fourdan Date: Tue Jun 23 11:54:48 2015 +0200 ignore size inc when maximized/fullscreen Under Wayland, fullscreen/maximized windows may not cover the entire area when a size increment is specified. Ignore size increments for fullscreen/maximized windows just like most window managers do under X11 so that windows with size increments can still be fullscreen or fully maximized under Wayland as well. https://bugzilla.gnome.org/show_bug.cgi?id=751368 gdk/wayland/gdkwindow-wayland.c | 30 ++++++++++++++++++------------ gtk/gtkwindow.c | 11 ++++++++++- 2 files changed, 28 insertions(+), 13 deletions(-) commit b3166b745f41a901171821ccc9f0c69b9cc35e70 Author: Víctor Manuel Jáquez Leal Date: Fri Jul 3 09:54:34 2015 +0200 drawingarea: checks parent's draw() before call it commit 6786c9d7 introduced a bug when a drawing area is used for rendering videos, since GtkWidgetClass doesn't set a draw() method by itself. https://bugzilla.gnome.org/show_bug.cgi?id=751877 gtk/gtkdrawingarea.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 28e1ed4f2aac4a362043437f1495d1dc8d5f5875 Author: Matthias Clasen Date: Wed Jul 1 23:36:29 2015 -0700 Fix warnings in the font options code This code gets called before a screen is set. gtk/gtkwidget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit a0e8d8db0bfc3f3c4a1120b77aa6b2eb01e99eea Author: Matthias Clasen Date: Wed Jul 1 19:15:56 2015 -0700 Improve the font options support Instead of just overwriting the default options, merge the per-widget font options with the defaults. https://bugzilla.gnome.org/show_bug.cgi?id=751811 gtk/gtkwidget.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) commit e9b847736c681e8d6e6feab33dcf8ee69a7a6c83 Author: Matthias Clasen Date: Wed Jul 1 19:14:58 2015 -0700 Add a testcase for font options tests/Makefile.am | 5 +++ tests/testfontoptions.c | 92 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 97 insertions(+) commit 1be338fd444f0cdea8dad030f0fb52b346054fcd Author: Matthias Clasen Date: Wed Jul 1 18:02:57 2015 -0700 GtkSwitch: fix a reentry issue The introduction of state broke some users which relied on being able to set active in a notify::active handler. https://bugzilla.gnome.org/show_bug.cgi?id=751754 gtk/gtkswitch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 862e0dab03e12c2fb1f6d99dd85c588dccc15dbc Author: Jasper St. Pierre Date: Wed Jul 1 17:25:23 2015 -0700 gtkwindow: Reset maximize / fullscreen_initially on state changes Since 740bcf5, we use these properties to properly compute shadow widths for unmapped windows. If a client calls gtk_window_maximize and a window manager unmaximizes a window, we should draw borders, so we need to reset these when we get the property notification. gtk/gtkwindow.c | 2 ++ 1 file changed, 2 insertions(+) commit e67b4874eb5192be62f46240f96bf94a22c562db Author: Cosimo Cecchi Date: Wed Jul 1 14:01:07 2015 -0700 window: don't override background every style_updated() This queues an unnecessary resize on the toplevel, and is not needed anymore, now that GtkWidget does not call gtk_style_context_set_background() on the window's GdkWindow anymore. gtk/gtkwindow.c | 17 ----------------- 1 file changed, 17 deletions(-) commit a1e80d99d23866772f3cb59ed091696cdf497132 Author: Cosimo Cecchi Date: Sun Jun 28 11:23:16 2015 -0700 stylecontext: deprecate gtk_style_context_set_background() Nothing in GTK calls it anymore. gtk/gtkstylecontext.c | 4 ++++ gtk/gtkstylecontext.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) commit d6b8261622a25dce4a5a688fcdc8f361100767b0 Author: Cosimo Cecchi Date: Wed Jul 1 13:05:45 2015 -0700 widget: don't call gtk_style_context_set_background() We don't need to do this here anymore, since widgets typically render their backgrounds now. gtk/gtkwidget.c | 6 ------ 1 file changed, 6 deletions(-) commit a9b45e7c3cadfd90ad2ae92f9f3014b0d324c134 Author: Cosimo Cecchi Date: Wed Jul 1 14:32:12 2015 -0700 layout: add a comment for gtk_style_context_set_background() And wrap it with G_GNUC_IGNORE_DEPRECATIONS. Unfortunately we can't stop rendering the background altogether here. Also, refactor some common code in a single function. gtk/gtklayout.c | 29 +++++++++++++++++++++-------- 1 file changed, 21 insertions(+), 8 deletions(-) commit 380ebbf76d526897633bc1ea4336180677632245 Author: Cosimo Cecchi Date: Wed Jun 3 18:02:34 2015 -0700 fixed: add a comment for gtk_style_context_set_background() And wrap it with G_GNUC_IGNORE_DEPRECATIONS. Unfortunately we can't stop rendering the background altogether here. Also, gtk_style_context_set_background() should really be called every time the style is updated. Fix that. gtk/gtkfixed.c | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-) commit 74f2d9448f24bbfdaf32ae6b328ed3e126700afe Author: Cosimo Cecchi Date: Sat Jun 27 22:54:42 2015 -0700 window: don't call gtk_style_context_set_background() gtk/gtkwindow.c | 6 ------ 1 file changed, 6 deletions(-) commit 88326488466cb74a05a96acfc5b4bc51961d692c Author: Cosimo Cecchi Date: Sat Jun 27 13:15:41 2015 -0700 socket: don't call gtk_style_context_set_background() gtk/gtksocket.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) commit 06b943fec91ff9f1d612473901a0af049857f8e9 Author: Cosimo Cecchi Date: Sat Jun 27 12:59:59 2015 -0700 toolitemgroup: don't use gtk_style_context_set_background() gtk/gtktoolitemgroup.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) commit e6f97f10dd08c3628c77f6172b4c4653b7554eba Author: Cosimo Cecchi Date: Sat Jun 27 12:58:04 2015 -0700 textview: don't call gtk_style_context_set_background() gtk/gtktextview.c | 67 ------------------------------------------------------- 1 file changed, 67 deletions(-) commit f89c86df52b4bb7bc41a5060ab505bde35e43099 Author: Cosimo Cecchi Date: Sat Jun 27 12:54:50 2015 -0700 revealer: don't call gtk_style_context_set_background() gtk/gtkrevealer.c | 23 ----------------------- 1 file changed, 23 deletions(-) commit 6b0f202bf37de2d8489cde1549763895aed3dab4 Author: Cosimo Cecchi Date: Sat Jun 27 12:52:58 2015 -0700 toolpalette: don't call gtk_style_context_set_background() gtk/gtktoolpalette.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) commit d4ecdbd300f6eeccb59b632476fc17ce2af30116 Author: Cosimo Cecchi Date: Sat Jun 27 12:50:50 2015 -0700 viewport: don't call gtk_style_context_set_background() gtk/gtkviewport.c | 37 ++++++++----------------------------- 1 file changed, 8 insertions(+), 29 deletions(-) commit 15908cfdf9c6f0924cf104b761f1a729c21f8f26 Author: Cosimo Cecchi Date: Sat Jun 27 12:48:57 2015 -0700 treeview: don't call gtk_style_context_set_background() gtk/gtktextview.c | 3 --- gtk/gtktreeview.c | 28 ---------------------------- 2 files changed, 31 deletions(-) commit 18be2d697cfbef704972102d3404f7c1152a0dda Author: Cosimo Cecchi Date: Fri Jun 5 15:37:34 2015 -0700 plug: don't call gtk_style_context_set_background() gtk/gtkplug.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) commit b4ee73a29109e66ec8d0f522ee6558eaeb32e776 Author: Cosimo Cecchi Date: Wed Jun 3 18:27:34 2015 -0700 paned: don't call gtk_style_context_set_background() gtk/gtkpaned.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) commit 9230143bbf183113ac421dbae2928f279c35eb50 Author: Cosimo Cecchi Date: Wed Jun 3 18:22:28 2015 -0700 overlay: don't call gtk_style_context_set_background() gtk/gtkoverlay.c | 1 - 1 file changed, 1 deletion(-) commit aab3d4679fa08c5b3da8226fc02bb6cb4cb9498a Author: Cosimo Cecchi Date: Wed Jun 3 18:21:56 2015 -0700 offscreenwindow: don't call gtk_style_context_set_background() gtk/gtkoffscreenwindow.c | 3 --- 1 file changed, 3 deletions(-) commit b7be29390fecce3a3919700cf18779c03ca08f06 Author: Cosimo Cecchi Date: Wed Jun 3 18:21:16 2015 -0700 menushell: don't call gtk_style_context_set_background() gtk/gtkmenushell.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) commit 828db3eca93df11308abce12ea30bb9e4d32a9a0 Author: Cosimo Cecchi Date: Wed Jun 3 18:18:56 2015 -0700 menu: don't call gtk_style_context_set_background() gtk/gtkmenu.c | 27 --------------------------- 1 file changed, 27 deletions(-) commit db76eae41a5686be59e20668dc760e5f25c89782 Author: Cosimo Cecchi Date: Wed Jun 3 18:17:27 2015 -0700 listbox: don't call gtk_style_context_set_background() gtk/gtklistbox.c | 1 - 1 file changed, 1 deletion(-) commit ba2f479aa066114d33f8c7c3a2f3c28085b7d8ff Author: Cosimo Cecchi Date: Wed Jun 3 18:14:06 2015 -0700 iconview: don't call gtk_style_context_set_background() gtk/gtkiconview.c | 43 ------------------------------------------- 1 file changed, 43 deletions(-) commit 9696d1b4bbd31820add59f1aa01eae470bd3e11a Author: Cosimo Cecchi Date: Wed Jun 3 18:04:15 2015 -0700 flowbox: don't set gtk_style_context_set_background() gtk/gtkflowbox.c | 1 - 1 file changed, 1 deletion(-) commit 1c9468c81bd833a662e65a21f88b2584510018e9 Author: Cosimo Cecchi Date: Wed Jun 3 18:03:35 2015 -0700 eventbox: don't call gtk_style_context_set_background() gtk/gtkeventbox.c | 3 --- 1 file changed, 3 deletions(-) commit 6786c9d724ad57ea30e169d2afcb4a314b2e56bb Author: Cosimo Cecchi Date: Wed Jun 3 17:59:45 2015 -0700 drawingarea: don't call gtk_style_context_set_background() gtk/gtkdrawingarea.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) commit 9258b40c8b26f6d3c0591c61ad1bb7595d2273e5 Author: Pedro Albuquerque Date: Wed Jul 1 21:58:15 2015 +0000 Updated Portuguese translation po/pt.po | 16551 ++++++++++++++++++++++++++++--------------------------------- 1 file changed, 7592 insertions(+), 8959 deletions(-) commit a774440baf3ce05f2ec0b731877ef5241643878b Author: Pedro Albuquerque Date: Wed Jul 1 21:57:37 2015 +0000 Updated Portuguese translation po-properties/pt.po | 16547 +++++++++++++++++++++++++++----------------------- 1 file changed, 8957 insertions(+), 7590 deletions(-) commit ff94923666a48feee8707b86148aaf4d3f905367 Author: Alexander Larsson Date: Fri Jun 26 13:49:23 2015 +0200 broadway: Implement maximization gdk/broadway/gdkscreen-broadway.c | 20 +++++++++++++++--- gdk/broadway/gdkwindow-broadway.c | 44 +++++++++++++++++++++++++++++++++++++++ gdk/broadway/gdkwindow-broadway.h | 6 ++++++ 3 files changed, 67 insertions(+), 3 deletions(-) commit 77b8495bc4e51826afa451914d6a3b0df1b62a24 Author: Carlos Garnacho Date: Tue Jun 23 18:11:07 2015 +0200 x11: Query pointer devices' scroll valuators on toplevel enter events We used to "invalidate" scroll valuators, so the next scroll event could be used as the base for the next scroll deltas. This has the inconvenience that it invariably consumes the first event received after enter and, due to interactions with WM overeager passive button grabs, there's a possibility we don't scroll at all if we receive interleaved "smooth scroll" XI_Motion events and XI_Enter events (Normally triggered by regular scroll wheels in mice). In order to fix this, and at the expense of some sync-call overhead on XI_Enter events (one XIQueryDevice call per slave device), query the current scroll valuator state for all the slaves of the entered pointer, so we do know beforehand the right base values. If new devices are plugged while the pointer is on top of the client, the initialized scroll values will match the valuators'. https://bugzilla.gnome.org/show_bug.cgi?id=750994 https://bugzilla.gnome.org/show_bug.cgi?id=750870 gdk/x11/gdkdevice-xi2.c | 39 +++++++++++++++++++++++---------------- gdk/x11/gdkdevicemanager-xi2.c | 15 +++++---------- gdk/x11/gdkprivate-x11.h | 2 ++ 3 files changed, 30 insertions(+), 26 deletions(-) commit 8c9e426dc50011fabf060206ac53eb4b347fa01a Author: Carlos Garnacho Date: Wed Jul 1 18:50:22 2015 +0200 placessidebar: Do not set as a "track motion" DnD site It has the unintended effect of picking the suggested action from the context, which conflicts with the (possibly 0) status we set on our ::drag-motion handler. Given this widget is not interested in listening to DnD from every possible target, it is safe to just disable it. gtk/gtkplacessidebar.c | 2 -- 1 file changed, 2 deletions(-) commit 5d17b0af54acea03c697ead28c2f178f5564db11 Author: Christoph Reiter Date: Mon Jun 29 13:46:36 2015 +0200 GtkWindow: don't increase the preferred size for empty windows if there is a size request set. This fixes a reftest broken by commit 84e99b20ac806ee5f https://bugzilla.gnome.org/show_bug.cgi?id=751341 gtk/gtkwidget.c | 17 +++++++++++++++++ gtk/gtkwidgetprivate.h | 2 ++ gtk/gtkwindow.c | 24 ++++++++++++++++-------- 3 files changed, 35 insertions(+), 8 deletions(-) commit 0f3995a446e77a7c0a752a23bf2bd6a4e93b2c6a Author: Carlos Garnacho Date: Tue Jun 30 19:04:13 2015 +0200 x11: Avoid X error traps within server grabs gdk_x11_device_xi2_window_at_position() may attempt to push/pop a few error trap pairs while traversing the window tree. Move it outside the server grab, and around the multiple XIQueryPointer calls we may do here. https://bugzilla.gnome.org/show_bug.cgi?id=751739 gdk/x11/gdkdevice-xi2.c | 73 +++++++++++++++++++++++++++++-------------------- 1 file changed, 43 insertions(+), 30 deletions(-) commit ef93c714f80264dbd5e39a3e27bdca441545aaa0 Author: Krzesimir Nowak Date: Tue Jun 30 22:55:59 2015 +0200 broadway: Fix memleak in error case https://bugzilla.gnome.org/show_bug.cgi?id=751752 gdk/broadway/broadway-server.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 15c73a2b1aae5be740efa19b3d20f9e6a26f8970 Author: Arc Riley Date: Tue Jun 30 10:57:49 2015 -0700 Add gtk_widget_set_font_options and gtk_widget_get_font_options This allows a widget to override global font_options, such as hinting and subpixel order. The widget's PangoContext is updated when this is set. Some update code from gtk_widget_update_pango_context was moved to update_pango_context so that gtk_widget_update_pango_context runs it. http://bugzilla.gnome.org/show_bug.cgi?id=751677 docs/reference/gtk/gtk3-sections.txt | 2 + gtk/gtkwidget.c | 74 +++++++++++++++++++++++++++++++----- gtk/gtkwidget.h | 5 +++ 3 files changed, 72 insertions(+), 9 deletions(-) commit 9913b02e3bf81fe620a750c15fbcd2f154e53e4d Author: Cosimo Cecchi Date: Mon Jun 29 15:25:44 2015 -0700 switch: add a style property for the switch height Instead of hardcoding an aspect ratio. This will be replaced by min-height/max-height when we have them. https://bugzilla.gnome.org/show_bug.cgi?id=751689 gtk/gtkswitch.c | 24 +++++++++++++++++++----- gtk/theme/Adwaita/_common.scss | 2 ++ gtk/theme/Adwaita/gtk-contained-dark.css | 1 + gtk/theme/Adwaita/gtk-contained.css | 1 + gtk/theme/HighContrast/_common.scss | 1 + gtk/theme/HighContrast/gtk.css | 1 + 6 files changed, 25 insertions(+), 5 deletions(-) commit 6251b7bdb2e3eabf7c605fbfa451b28a24092dfc Author: Dušan Kazik Date: Tue Jun 30 10:20:51 2015 +0000 Updated Slovak translation po/sk.po | 576 +++++++++++++++++++++++++++++++++++++-------------------------- 1 file changed, 341 insertions(+), 235 deletions(-) commit 64fef45208d12d1cfa54ed17fec79bdaf93abc45 Author: Pedro Albuquerque Date: Mon Jun 29 22:46:43 2015 +0000 Updated Portuguese translation po/pt.po | 15580 +++++++++++++++++++++++++++++++++++-------------------------- 1 file changed, 9070 insertions(+), 6510 deletions(-) commit 5304a898bfb839f3402c7026e5850bde7ffd96a6 Author: Pedro Albuquerque Date: Mon Jun 29 22:46:04 2015 +0000 Updated Portuguese translation po-properties/pt.po | 16313 ++++++++++++++++++++++++-------------------------- 1 file changed, 7683 insertions(+), 8630 deletions(-) commit 04e727709d562d7a86a115723d0356592ab06333 Author: Jasper St. Pierre Date: Mon Jun 29 14:16:49 2015 -0700 window: Don't send startup notifications for offscreen / popup windows The WM isn't aware of O-R (popup) or offscreen windows. If somebody maps an offscreen or a popup GTK+ window before the main window, we'll complete the sequence before a "real" window is mapped. Make sure to ignore these for startup notifies. gtk/gtkwindow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 6ff5db374ac6562e2613d15114c5ab01e601ec37 Author: Piotr Drąg Date: Mon Jun 29 23:07:40 2015 +0200 Updated POTFILES.skip po-properties/POTFILES.skip | 1 + po/POTFILES.skip | 1 + 2 files changed, 2 insertions(+) commit 802b006b3768ddc8c8cdf0af27428e7042c36509 Author: nick Date: Mon Jun 29 20:37:26 2015 +0100 settings: Include pangofc-fontmap.h header on Wayland In case the X11 backend is not enabled, we still need to include the pangofc-fontmap.h header file, as we use the Pango/FontConfig API in both the X11 and Wayland case. https://bugzilla.gnome.org/show_bug.cgi?id=751625 gtk/gtksettings.c | 1 + 1 file changed, 1 insertion(+) commit de68968f89a5e9b987ff441cc127010c12d8f606 Author: Carlos Garnacho Date: Mon Jun 29 17:54:57 2015 +0200 wayland: Return the right type atom on gdk_selection_property_get() We mistakenly forced the "STRING" type, which was able to confuse higher layer helpers like gtk_selection_data_get_uris(). This fixes a crash happening anytime a drop is attempted on a GtkPlacesSidebar. gdk/wayland/gdkselection-wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 50178ce0147388ceffd7cafedfd85befcdfc4137 Author: Carlos Garnacho Date: Mon Jun 29 16:32:01 2015 +0200 wayland: Prepare against NULL selection owners on data_source requests Currently, due to the lack of progress information in the Wayland DnD protocol, we assume a DnD operation is finished after the first data_source.send is finished (It's either that or leaving stuck grabs). This however breaks previous assumptions that dest widgets can request the data multiple times, even in response to GtkWidget::drag-motion. This leaves us with a NULL owner for the DnD atom when we aren't finished receiving wl_data_source events yet, causing a crash. This commit fixes the crash, the behavior left is still far from desirable though... gdk/wayland/gdkselection-wayland.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit 109572286c138c11850cefb823e839c6f29d37b8 Author: Matthias Clasen Date: Sun Jun 28 22:46:53 2015 -0700 gtk3-demo: Group pango demos together demos/gtk-demo/font_features.c | 2 +- demos/gtk-demo/rotated_text.c | 2 +- demos/gtk-demo/textmask.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit f97786f5e9ea46241410127e6d2d8ba8c44b9e71 Author: Matthias Clasen Date: Sun Jun 28 22:43:27 2015 -0700 gtk3-demo: Add a fancy text demo This demonstrates rendering text with a pattern instead of a single color. demos/gtk-demo/Makefile.am | 1 + demos/gtk-demo/demo.gresource.xml | 1 + demos/gtk-demo/textmask.c | 85 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 87 insertions(+) commit 876a6b550b356c3dd65e33283584f7780d6705f2 Author: Matthias Clasen Date: Sun Jun 28 10:21:45 2015 -0400 gtk-demo: Make the info bar example wrap demos/gtk-demo/infobar.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit 609e04ddcf626e6295b11260269ab5d0492a65f6 Author: Matthias Clasen Date: Sun Jun 28 09:23:28 2015 -0400 gtk-demo: Cosmetic changes Clean up the code of many examples in minor ways, fix some memory leaks, and avoid the use of dialogs where a regular toplevel works just as well. demos/gtk-demo/Makefile.am | 79 +-------- demos/gtk-demo/assistant.c | 2 +- demos/gtk-demo/builder.c | 24 ++- demos/gtk-demo/button_box.c | 11 +- demos/gtk-demo/clipboard.c | 21 ++- demos/gtk-demo/colorsel.c | 20 +-- demos/gtk-demo/combobox.c | 15 +- demos/gtk-demo/css_accordion.c | 9 +- demos/gtk-demo/css_basics.c | 9 +- demos/gtk-demo/css_multiplebgs.c | 9 +- demos/gtk-demo/css_pixbufs.c | 17 +- demos/gtk-demo/css_shadows.c | 17 +- demos/gtk-demo/cursors.c | 9 +- demos/gtk-demo/dialog.c | 13 +- demos/gtk-demo/drawingarea.c | 3 +- demos/gtk-demo/editable_cells.c | 10 +- demos/gtk-demo/entry_buffer.c | 74 ++++----- demos/gtk-demo/entry_completion.c | 20 +-- demos/gtk-demo/event_axes.c | 5 +- demos/gtk-demo/expander.c | 2 + demos/gtk-demo/flowbox.c | 10 +- demos/gtk-demo/font-features.ui | 49 +++--- demos/gtk-demo/font_features.c | 11 +- demos/gtk-demo/gestures.c | 7 +- demos/gtk-demo/headerbar.c | 9 +- demos/gtk-demo/hypertext.c | 14 +- demos/gtk-demo/iconview.c | 5 +- demos/gtk-demo/iconview_edit.c | 9 +- demos/gtk-demo/images.c | 9 +- demos/gtk-demo/infobar.c | 14 +- demos/gtk-demo/links.c | 12 +- demos/gtk-demo/menus.c | 9 +- demos/gtk-demo/offscreen_window.c | 9 +- demos/gtk-demo/offscreen_window2.c | 9 +- demos/gtk-demo/overlay.c | 9 +- demos/gtk-demo/pagesetup.c | 5 +- demos/gtk-demo/panes.c | 9 +- demos/gtk-demo/pickers.c | 12 +- demos/gtk-demo/pixbufs.c | 6 +- demos/gtk-demo/popover.c | 5 +- demos/gtk-demo/revealer.c | 37 ++--- demos/gtk-demo/revealer.ui | 286 ++++++++++++++------------------- demos/gtk-demo/rotated_text.c | 16 +- demos/gtk-demo/search_entry.c | 26 +-- demos/gtk-demo/search_entry2.c | 16 +- demos/gtk-demo/sidebar.c | 3 +- demos/gtk-demo/sizegroup.c | 26 ++- demos/gtk-demo/spinner.c | 2 +- demos/gtk-demo/stack.c | 15 +- demos/gtk-demo/theming_style_classes.c | 18 +-- demos/gtk-demo/transparent.c | 12 +- demos/gtk-demo/tree_store.c | 9 +- 52 files changed, 358 insertions(+), 699 deletions(-) commit be4a25231d0554f4be241b498969151331bd675d Author: Matthias Clasen Date: Sun Jun 28 10:11:54 2015 -0400 gtk-demo: Add a spin button example More or less copied from the spin button example in testgtk. demos/gtk-demo/Makefile.am | 1 + demos/gtk-demo/demo.gresource.xml | 4 + demos/gtk-demo/spinbutton.c | 253 ++++++++++++++++++++++++++++++++++++++ demos/gtk-demo/spinbutton.ui | 205 ++++++++++++++++++++++++++++++ 4 files changed, 463 insertions(+) commit cd3f24d5793e038ee29d780b24747707c73ad00c Author: Benjamin Otte Date: Fri Jun 26 21:08:04 2015 +0200 cssvalue: Change color transitions to run premultiplied Previously, the unpremultiplied values from the GdkRGBA were taken. Now we premultiply the color values as specified by the CSS specs. This is only relevant when transitioning with translucent colors. An example is the halfway transition between transparent (0, 0, 0, 0) and white (1, 1, 1, 1). Previously, all 4 values where transitioned separately and the result was semi-transparent gray (0.5, 0.5, 0.5, 0.5). By depending on the alpha value, the result is now semi-transparent white (1, 1, 1, 0.5) which is what one would naively expect. New reftest: color-transition gtk/gtkcssrgbavalue.c | 12 +++++++++--- testsuite/reftests/Makefile.am | 3 +++ testsuite/reftests/color-transition.css | 18 ++++++++++++++++++ testsuite/reftests/color-transition.ref.ui | 8 ++++++++ testsuite/reftests/color-transition.ui | 25 +++++++++++++++++++++++++ 5 files changed, 63 insertions(+), 3 deletions(-) commit 142abce46a18ef09ca77ed581cf3b385671c9515 Author: Benjamin Otte Date: Fri Jun 26 20:53:39 2015 +0200 cssvalue: Special case resulting color for transparency Again, preparation for using premultiplied color transitions. gtk/gtkcssrgbavalue.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) commit e3d8f03b3a69c0b1e1dea653ffeca34092be6ce8 Author: Benjamin Otte Date: Fri Jun 26 19:06:02 2015 +0200 cssvalue: Restructure RGBA transitions Split out a function to make the code clearer for the changes ahead. gtk/gtkcssrgbavalue.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) commit 8509a07a08ca34367f20783384df35074fb77f3e Author: Carlos Garnacho Date: Fri Jun 26 14:23:16 2015 +0200 wayland: Set the master device on the drop-side GdkDragContext And force the ungrab on it, instead of the slave, in the case of local DnD drop. This avoids confusions on the pointer events spawn from DnD, as GDK doesn't think anymore those are from a slave device. Most namely, it fixes the stuck grab when finishing DnD on the same app it was started from. gdk/wayland/gdkdevice-wayland.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 1178a0ac8bcbdf50d85298e606abd3f64b06bbe4 Author: Carlos Garnacho Date: Tue Apr 7 16:40:57 2015 +0200 wayland: Split handling of clipboard/DnD data offers We currently only hold the last offer received, which is wrong, as both are independent and have different life cycles. This means we have to store per-selection wl_data_offer and targets, and maintain these as appropriate from the clipboard/DnD specific entry points. gdk/wayland/gdkdevice-wayland.c | 19 +++-- gdk/wayland/gdkdnd-wayland.c | 21 +++-- gdk/wayland/gdkprivate-wayland.h | 9 ++- gdk/wayland/gdkselection-wayland.c | 155 +++++++++++++++++++++++++++---------- 4 files changed, 148 insertions(+), 56 deletions(-) commit da395606a2afcebe9721277295ba14cd86f90fef Author: Alexander Larsson Date: Thu Jun 25 21:15:46 2015 +0200 broadway: Handle shm_open failing by falling back on tmp files This is required if /dev/shm is not mounted on your system, which can happen for instance in certain container configurations. gdk/broadway/broadway-server.c | 18 +++++++++++++--- gdk/broadway/gdkbroadway-server.c | 45 +++++++++++++++++++++++++++++++-------- 2 files changed, 51 insertions(+), 12 deletions(-) commit 029800c426ef29ad6170e28624b5c4a0a6947cc8 Author: Lapo Calamandrei Date: Thu Jun 25 20:04:32 2015 +0200 Adwaita: entry linking fixes Set the right border color on the linked entry after the focused one. gtk/theme/Adwaita/_common.scss | 4 ++-- gtk/theme/Adwaita/gtk-contained-dark.css | 12 ++++++------ gtk/theme/Adwaita/gtk-contained.css | 10 +++++----- 3 files changed, 13 insertions(+), 13 deletions(-) commit 56a3fd888a83984c7ced289f2be092e6ba4fa1f9 Author: Lapo Calamandrei Date: Thu Jun 25 19:55:51 2015 +0200 Adwaita: rubberbands! Darken the rubberband a bit to make it visible on the selected color background, fix treeview rubberband border issue. gtk/theme/Adwaita/_common.scss | 6 ++++-- gtk/theme/Adwaita/gtk-contained-dark.css | 6 +++--- gtk/theme/Adwaita/gtk-contained.css | 6 +++--- 3 files changed, 10 insertions(+), 8 deletions(-) commit 350d55589304fa55d83770834b392e2ee04cd906 Author: Carlos Garnacho Date: Thu Jun 25 18:44:49 2015 +0200 wayland: Fix compile warning in DnD/selection code Introduced in my recent commits gdk/wayland/gdkselection-wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0606b525b47cf0901ebff70c8aebd57f8190e116 Author: Carlos Garnacho Date: Thu Jun 25 14:58:00 2015 +0200 gtkdnd: Plug a leak We create a cairo_t in order to find out the surface extents, but it was being leaked, dragging the whole drag surface with it through extra refs. gtk/gtkdnd.c | 1 + 1 file changed, 1 insertion(+) commit 33f9cbafcd1a0492c19c53282454184d28fc771f Author: Carlos Garnacho Date: Thu Jun 25 14:56:59 2015 +0200 gtkmodelbutton: Plug a leak The private struct had some data that needed freeing, but this widget didn't have any destroy/dispose/finalize handlers. gtk/gtkmodelbutton.c | 11 +++++++++++ 1 file changed, 11 insertions(+) commit 6de82c9be303aabfc2a911b2231d38b18642b487 Author: Carlos Garnacho Date: Thu Jun 25 14:55:56 2015 +0200 gtkmenusectionbox: plug a leak The list returned by gtk_container_get_children() wasn't being freed. gtk/gtkmenusectionbox.c | 2 ++ 1 file changed, 2 insertions(+) commit 6cc9b17429787de578c18616fb5af03aac12378f Author: Carlos Garnacho Date: Thu Jun 25 14:52:47 2015 +0200 wayland: Plug some memleaks in DnD/clipboard code gdk_atom_name() return value must be freed, this code was consistently not doing so... gdk/wayland/gdkdnd-wayland.c | 13 ++++++++++--- gdk/wayland/gdkselection-wayland.c | 27 +++++++++++++++++++++------ 2 files changed, 31 insertions(+), 9 deletions(-) commit f8b7623b3c5c056fcc1d2fd15df8ec62006b44d7 Author: Matthias Clasen Date: Thu Jun 25 07:01:26 2015 -0400 builder-tool: Don't strip h/vexpand Setting these properties has the side-effect of setting the corresponding -set properties, which makes GTK+ behave subtly different. So don't mess with these. gtk/gtk-builder-tool.c | 2 ++ 1 file changed, 2 insertions(+) commit e9e9dfade6e975bac94bc0092eb7e5b6c332c19c Author: Matthias Clasen Date: Thu Jun 25 06:59:18 2015 -0400 GtkSearchBar: Don't vexpand It turns out that setting vexpand to its default value has side-effects that we need. https://bugzilla.gnome.org/show_bug.cgi?id=751447 gtk/ui/gtksearchbar.ui | 1 + 1 file changed, 1 insertion(+) commit d31e1fbef092543caeef4db2a597ad6faabeb075 Author: cedlemo Date: Wed Jun 24 13:59:00 2015 +0000 GtkImage: Make resource property work properly gtk_image_set_from_resource was setting the resource_path, only to have it overwritten again before returning. That is not as it should be, so change things to set the resource path late. https://bugzilla.gnome.org/show_bug.cgi?id=751443 gtk/gtkimage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 342db27278b530a99f70c96887bb153a5507f5d2 Author: Carlos Garnacho Date: Wed Jun 24 22:10:55 2015 +0200 wayland: protect against unknown mimetype requests This oddly can be reproduced with weston+weston-dnd, when dragging anything from GTK+ into weston-dnd, it will insist on picking its custom application/x-wayland-dnd-flower mimetype, and this request forwarded by the compositor, even if GTK+ didn't announce it on its wl_data_source mimetype list. (What should probably happen here is that the request is silenced, and/or weston-dnd picks (null)) This should be harmless, we are leaking though the fd in that case, because the emission of GdkEventSelection on an unhandled mimetype results in NOP. In order to avoid this, we should check whether the mimetype is supported at all on the backend code and possibly close the fd, this involves storing these in the first place. https://bugzilla.gnome.org/show_bug.cgi?id=751414 gdk/wayland/gdkselection-wayland.c | 39 +++++++++++++++++++++++++++++++++++++- 1 file changed, 38 insertions(+), 1 deletion(-) commit fb266a8876fbba4a983ddb9f6d11295c1e27ef7d Author: Carlos Garnacho Date: Wed Jun 24 21:55:12 2015 +0200 wayland: Ensure we close the fd on all error paths in data_source.send https://bugzilla.gnome.org/show_bug.cgi?id=751414 gdk/wayland/gdkselection-wayland.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) commit 3bd7b2a6fb31a3cf379466b08c497552f0c27c0f Author: Carlos Garnacho Date: Wed Jun 24 21:52:23 2015 +0200 wayland: close() the selection fd if we didn't start writing yet If the other peer requests data too fast (too rare/unlikely though), we might receive multiple gdk_wayland_selection_request_target() calls with no ending gdk_wayland_selection_check_write(), in which case the fd is leaked as no GOutputStream was created to take over it. https://bugzilla.gnome.org/show_bug.cgi?id=751414 gdk/wayland/gdkselection-wayland.c | 7 +++++++ 1 file changed, 7 insertions(+) commit 5e7159413d2545e3fd1454b14852f8c4f82ec0c5 Author: Carlos Garnacho Date: Wed Jun 24 19:57:40 2015 +0200 wayland: Ensure we cancel previous selection writes before starting one We weren't catching all the places where the AsyncWriteData operation should be cancelled, which could happen if we repeatedly request the same target on different fds. https://bugzilla.gnome.org/show_bug.cgi?id=751414 gdk/wayland/gdkselection-wayland.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) commit 69b5955108a794c0aab8872d1bffab2a5f820d8c Author: Carlos Garnacho Date: Wed Jun 24 19:53:39 2015 +0200 wayland: Do not close the descriptor on async_write_data_free() At the moment we create the AsyncWriteData, the ownership of the fd is granted to the GOutputStream, and the fd set to -1, so at this moment we're just silently getting EBADFD. This partially reverts 25885ca600fff, the initialization of .fd to -1 is valid and stays though. https://bugzilla.gnome.org/show_bug.cgi?id=751414 gdk/wayland/gdkselection-wayland.c | 2 -- 1 file changed, 2 deletions(-) commit d3212c9b46cba09ec2c0ea2f9c02d9a92acbbc45 Author: Balázs Úr Date: Wed Jun 24 17:45:33 2015 +0000 Updated Hungarian translation po/hu.po | 549 ++++++++++++++++++++++++++++++++++++++------------------------- 1 file changed, 335 insertions(+), 214 deletions(-) commit de2268000d7e3eb5e84603810f9a6f971efb1072 Author: Carlos Garnacho Date: Wed Jun 24 17:48:18 2015 +0200 wayland: Ensure device grabs generate crossing/focus events On X11 this is something the windowing system does for us, which the wayland backend should emulate, being grabs completely client-side. So, if the grab and current focus windows differ, make sure we emit focus/crossing events as it corresponds to the grab device. gdk/wayland/gdkdevice-wayland.c | 94 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 93 insertions(+), 1 deletion(-) commit de260ae2ea8809b992b113d5f37b2dac38b2abcf Author: Carlos Garnacho Date: Wed Jun 24 15:41:23 2015 +0200 wayland: Update grab serial when ungrabbing keyboards This was being done so only on pointers. Internally, a GdkDeviceGrabInfo is kept for each of the master pointer/keyboard, failing to do this for keyboards results in a stuck keyboard grab. https://bugzilla.gnome.org/show_bug.cgi?id=748892 gdk/wayland/gdkdevice-wayland.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit 25885ca600fffcade4f3a77019d8cca17d9ec325 Author: Carlos Garnacho Date: Wed Jun 24 11:27:20 2015 +0200 wayland: Properly initialize/finalize where we store the data_source.send fd The fd must be closed on async_write_data_free(), but we should also initialize it to -1 so gdk_wayland_selection_check_write() doesn't wrongly pick the stdin fd. https://bugzilla.gnome.org/show_bug.cgi?id=751414 gdk/wayland/gdkselection-wayland.c | 3 +++ 1 file changed, 3 insertions(+) commit 48ea0cbe4b8bcd37958601d39b9e93be7d28fa8b Author: Christoph Reiter Date: Mon Jun 22 19:22:10 2015 +0200 GtkWindow: some min/nat size corrections. Don't add the container border to the title request size; it is only used for the child widget. Don't call gtk_widget_get_preferred_width_for_height() for the title bar with an unrelated height and subtract the title bar height before querying the child widget width. Guard against negative size requests after substracting the borders/shadows and the title bar. https://bugzilla.gnome.org/show_bug.cgi?id=751341 gtk/gtkwindow.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-)