commit 3c331ba78dfa9982c613c0e918b9288b57326b63 Author: Matthias Clasen Date: Mon Nov 9 10:12:46 2015 -0500 3.18.3 NEWS | 35 +++++++++++++++++++++++++++++++++++ configure.ac | 4 ++-- 2 files changed, 37 insertions(+), 2 deletions(-) commit 040a209031d2f8d93f1c8788104372755313b912 Author: Alexander Larsson Date: Mon Nov 9 15:14:57 2015 +0100 gdk: Fix invalidation w/ pixel cache when changing child window geometry. When moving/scrolling a child window we can't use the current clip region to limit what is invalidated, because there may be a pixel cache that listens for changes outside the clip region. Instead invalidate the entire area and rely on the invalidation code to limit the repaint to the actually visible area. gdk/gdkwindow.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) commit 2e09bddb41acee9ef5bbce8839a1421ad2e6f65a Author: Benjamin Otte Date: Mon Nov 9 01:44:01 2015 +0100 placesview: Don't export API This is a private object, don't export its symbols. https://bugzilla.gnome.org/show_bug.cgi?id=756978 gtk/gtkplacesviewprivate.h | 9 --------- 1 file changed, 9 deletions(-) commit 9883f592b0dbacd448045bd57d956451eb660b38 Author: Matthias Clasen Date: Mon Nov 9 09:27:40 2015 -0500 Avoid excessive property notification for GtkStack::interpolate-size make check checks this for writable properties, and fails now that we've made this property writable. gtk/gtkstack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e33f4b1fef2e25b90bc37cf072bb05ea910fe793 Author: Alexander Larsson Date: Thu Oct 29 15:17:44 2015 +0100 TreeModelFilter: Fix uninitialized memory read. We were copying an iterator that sometimes was not initialized, which caused debugger warnings in VS2015. gtk/gtktreemodelfilter.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) commit ebf4ac8a5bc2cbda7db950165386c8eccd7972b9 Author: Emmanuele Bassi Date: Wed Nov 4 11:50:37 2015 +0000 docs: Point at for_scale() variants Using lookup_icon() and lookup_by_gicon() with a size multiplied by a scaling factor is almost certainly going to get worse results than using their for_scale() variants. gtk/gtkicontheme.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) commit ac823cf070cab45694aed89c4bf6cf5e402df5ec Author: Emmanuele Bassi Date: Wed Nov 4 11:45:41 2015 +0000 docs: Clarify gtk_render_icon()'s behaviour A GdkPixbuf has no scaling factor, so drawing directly from it can only using a scale of 1, to avoid blurry, fuzzy icons. You should be using gtk_render_icon_surface() anyway. gtk/gtkrender.c | 7 +++++++ 1 file changed, 7 insertions(+) commit afb626553027bfa852ed2b0c5789a06fe63a6278 Author: Emmanuele Bassi Date: Wed Nov 4 11:45:19 2015 +0000 docs: Fix typo in gdk_screen_get_scale_factor() gdk/gdkscreen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d1dda37f8c9664b437cefb48b55b5fc72f97afd0 Author: Christian Hergert Date: Tue Nov 3 15:13:51 2015 -0800 stack: GtkStack:interpolate-size should be read/write It looks like the param spec for interpolate-size was copied from the line above it, which is a read only property. There is a setter for interpolate-size, and it is implemented in set_property(). gtk/gtkstack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 80ae3fe6f2f5f747b04330b7c8a11c6b531938db Author: Christian Hergert Date: Tue Nov 3 14:36:54 2015 -0800 headerbar: remove G_PARAM_CONSTRUCT from custom-title This fixes the ability to sublcass GtkHeaderBar from a UI template which contains a custom element. https://bugzilla.gnome.org/show_bug.cgi?id=757544 gtk/gtkheaderbar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0358fd0b337356a2a1edeafc1ed755d6566582db Author: Carlos Garnacho Date: Fri Oct 16 19:52:50 2015 +0200 GdkDevice: Do not free construct-only properties data on dispose() Those are not references to other objects, and the device will be mostly useless if those can't be set again anyway. https://bugzilla.gnome.org/show_bug.cgi?id=756625 gdk/gdkdevice.c | 36 +++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) commit 1266d15c4b67eb23dc7945a7af75268ee76af452 Author: Carlos Garnacho Date: Fri Oct 30 14:10:19 2015 +0100 x11: Detect single-touch touchscreens as GDK_SOURCE_TOUCHSCREEN Those won't have ABS_MT_* axes, so won't be reported has having XITouchClassInfo. Fallback on these to checking whether abs x/y axes are available. After the Wacom checks, any remaining device with absolute axes should be touchscreens, and GDK_SOURCE_MOUSE does indeed just make sense on devices with relative axes. https://bugzilla.gnome.org/show_bug.cgi?id=757358 gdk/x11/gdkdevicemanager-xi2.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) commit 9062a835a056a3e5f0d378937847ccc14ec847d6 Author: Dhiru Kholia Date: Tue Oct 27 22:08:59 2015 +0100 Fix a memory leak in gtk-3.0.m4 file This fix is inspired by, https://git.gnome.org/browse/glib/tree/m4macros/glib-2.0.m4 https://bugzilla.gnome.org/show_bug.cgi?id=757221 m4macros/gtk-3.0.m4 | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) commit 94476c3c86caff1fe9273d95768b45d776c159e3 Author: Benjamin Otte Date: Mon Nov 2 17:04:39 2015 +0100 gdkrgba: Use %g instead of %.17g to print alpha This way 0.3 isn't printed as 0.29999999999999 gdk/gdkrgba.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d38c29f48b3cc09ff8db7e52be967d7d046c40fb Author: Matthias Clasen Date: Sat Oct 31 18:13:29 2015 -0400 Load settings.ini from all data dirs An error in the loading function was making us load the file from the first data dir repeatedly, instead. https://bugzilla.gnome.org/show_bug.cgi?id=757377 gtk/gtksettings.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit c9b69f7c3906b8b48f7eb2daae0c7958f9b44778 Author: Matthias Clasen Date: Tue Oct 27 11:07:53 2015 -0400 tool item group: Don't leak a button This causes a hickup in the new css node machinery, causing the default-value test to fail. gtk/gtktoolitemgroup.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) commit 08db197af2bc37cdfeb72fcbeb78924b5cebcc74 Author: Matthias Clasen Date: Tue Oct 27 11:05:00 2015 -0400 icon theme: Ensure to propagate an error If the svg pixbuf loader is not available, we end up with criticals from gtk_css_image_icon_theme_draw because gtk_icon_info_load_symbolic returns NULL without setting an error. Avoid this by propagating the load error. gtk/gtkicontheme.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit bfdff24b1023e8dd2db23941f3d8caf77a0a33d9 Author: Lars Uebernickel Date: Tue Oct 27 13:38:14 2015 +0100 gdkpixbuf-drawable: reinstate accidentally removed line gdk/gdkpixbuf-drawable.c | 1 + 1 file changed, 1 insertion(+) commit 088d3449cabfce1529c42c0ed0cdfceedd350912 Author: Lars Uebernickel Date: Mon Oct 26 10:12:34 2015 +0100 gdk_pixbuf_get_from_window: honor device scale gdk_pixbuf_get_from_window() paints the given window onto a new cairo surface. Create that new surface with the same device scale as the window so that the result is not scaled down on hidpi screens. https://bugzilla.gnome.org/show_bug.cgi?id=757147 gdk/gdkpixbuf-drawable.c | 1 - 1 file changed, 1 deletion(-) commit a4448b757807fb03757ca6f17c4c39daf97bc33c Author: Jonas Ådahl Date: Tue Oct 27 09:00:48 2015 +0800 wayland: Don't use GTK symbols from GDK GTK_WINDOW_POPUP sets the GdkWindow type to GDK_WINDOW_TEMP, so use that in GDK, not the GTK symbol which doesn't exist there. gdk/wayland/gdkwindow-wayland.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 8c8ed3e778ee85151beaf9b1b0d99f6ecc8e0531 Author: Jonas Ådahl Date: Sun Oct 18 21:23:12 2015 +0800 GtkTreeView: Rework the search window hack so it also works on Wayland The search window of a tree view was implemented by showing without making it visible by by positioning it outside the screen edge. This is not possible on Wayland, so implement another method for being able to enter text into a non-visible entry. The new method is implemented by, before showing the window, pass the key event directly to the IM context backing the entry. If the key event triggered the context to commit new text or change the preedit content, the search window is shown, and from that point the key events are forwarded directly to the entry widget. https://bugzilla.gnome.org/show_bug.cgi?id=756780 gtk/gtktreeview.c | 137 +++++++++++++++++++++++++++++------------------------- 1 file changed, 74 insertions(+), 63 deletions(-) commit 1b58cd10a99bf71ab8946c5ed79ccf5874349001 Author: Jonas Ådahl Date: Sun Oct 18 21:21:51 2015 +0800 wayland: Map UTILITY hinted popup windows as subsurfaces Currently used by GtkTreeView to map windows without changing focus. We can't map this as a popup, because popup implies focus change. https://bugzilla.gnome.org/show_bug.cgi?id=756780 gdk/wayland/gdkwindow-wayland.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) commit 3a53352afea55ae949aa3b09de883d416473f45e Author: Jonas Ådahl Date: Sun Oct 18 21:12:59 2015 +0800 GtkTreeView: Make a search window destroy helper https://bugzilla.gnome.org/show_bug.cgi?id=756780 gtk/gtktreeview.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) commit ea449a032a6e6d864b4467aa70b6b2d7bbe9babf Author: Jonas Ådahl Date: Sun Oct 18 21:03:52 2015 +0800 wayland: Don't try to use subsurfaces as popup parents If a GtkMenu (or something else that is mapped as a xdg_popup) tries to use a subsurface window as a parent, it will be terminated by the compositor due to protocol violation. So to avoid this, if a parent window is not a xdg_popup or xdg_surface, i.e. a wl_subsurface, then traverse up the transient parents until we find the right popup parent. https://bugzilla.gnome.org/show_bug.cgi?id=756780 gdk/wayland/gdkwindow-wayland.c | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) commit a78f4d5444e2ba292a548bd9871c0b9ef9b9f262 Author: Jonas Ådahl Date: Sun Oct 18 20:23:07 2015 +0800 wayland: Make window type conditions switches In order to make it easier to add/remove in future commits. https://bugzilla.gnome.org/show_bug.cgi?id=756780 gdk/wayland/gdkwindow-wayland.c | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) commit b31132971d2cbf5408a73e338ee94b42ba24e83f Author: Jonas Ådahl Date: Sat Oct 17 19:25:52 2015 +0800 GtkTreeView: Use more consistent search window naming Instead of alternating between search dialog and search window, use search window everywhere. https://bugzilla.gnome.org/show_bug.cgi?id=756780 gtk/gtktreeview.c | 43 +++++++++++++++++++++++++------------------ 1 file changed, 25 insertions(+), 18 deletions(-) commit bfedc3bafe4538d6c815405d5a9daf1abbf5b74a Author: Matthias Clasen Date: Tue Oct 20 11:06:43 2015 -0400 Translate GDK_KEY_KP_Decimal according to locale It makes sense that you should be able to type numbers that are correctly formatted and parsable according to the current locale, using just the keypad. This patch makes it so by translating GDK_KEY_KP_Decimal to the decimal separator for the current locale, instead of hardcoding a '.'. https://bugzilla.gnome.org/show_bug.cgi?id=756751 gdk/gdkkeyuni.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) commit d49c1cdcf4db6d35a407ad3c7040389e226d7934 Author: Matthias Clasen Date: Thu Oct 22 11:50:49 2015 -0400 win32: Fix introspection syntax gdk/win32/gdkdisplay-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 90dd285c22ccb27aff5c254b92fdb00a7d505197 Author: Matthias Clasen Date: Mon Oct 19 00:38:27 2015 -0400 builder: Avoid some unnecessary overhead Only get the class once per object, not once per property. And don't canonicalize the property name, g_object_class_find_property does that already. gtk/gtkbuilderparser.c | 37 ++++++++++++++++++------------------- gtk/gtkbuilderprivate.h | 1 + 2 files changed, 19 insertions(+), 19 deletions(-) commit 276e9be38340cd96b451ac9993c6dec08e65d297 Author: Paolo Borelli Date: Mon Oct 19 11:41:34 2015 +0200 widget: fix typo in warning message gtk/gtkwidget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e135358ed02d9734547aeb1f355195817598674f Author: Jonas Ådahl Date: Tue Oct 13 20:48:51 2015 +0800 wayland: Map windows with tooltip hint as subsurfaces Tooltips tend to be placed on top of a parent surface with a given relative coordinate, and without any input focus. So lets map them as subsurfaces. https://bugzilla.gnome.org/show_bug.cgi?id=756496 gdk/wayland/gdkwindow-wayland.c | 5 +++++ 1 file changed, 5 insertions(+) commit 1d464fca3cbb156764b118e4d0d298cbec53145f Author: Jonas Ådahl Date: Tue Oct 13 20:39:02 2015 +0800 wayland: Clean up code determining how to map a window Restructure the mapping procedure so that its known up front what the expected way mapping is to be done (subsurface, popup or stand alone), and warn if it fails to actually map in such a way (for example a popup without a parent or device grab, a tooltip without a parent). https://bugzilla.gnome.org/show_bug.cgi?id=756496 gdk/wayland/gdkwindow-wayland.c | 100 ++++++++++++++++++++++++++++++---------- 1 file changed, 75 insertions(+), 25 deletions(-) commit 633b08cc8a102fab11e23fb66be3f214eaf37cdf Author: Timm Bäder Date: Fri Oct 16 14:44:16 2015 +0200 GtkPaned: Fix gtk_paned_set_child_visible calls Use CHILD1/CHILD2 instead of 0 and 1, always use the same order and don't check for child NULL-ness, because it will be done in gtk_paned_set_child_visible anyways. gtk/gtkpaned.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) commit 1536710dbac58f0d46a6c308370e1e3864bf42e0 Author: Sébastien Wilmet Date: Thu Oct 15 14:10:00 2015 +0200 inspector: remove gtk_text_buffer_get_iter_at_line_index() workaround The function is now safe to use. https://bugzilla.gnome.org/show_bug.cgi?id=735341 gtk/inspector/css-editor.c | 37 ++++++++----------------------------- 1 file changed, 8 insertions(+), 29 deletions(-) commit cf51c4f6dbd91dae1878a0cb0d08b24c67e15232 Author: Sébastien Wilmet Date: Thu Oct 15 10:43:10 2015 +0200 textbuffer: nicer get_iter functions Avoid crashes when passing an invalid location to a gtk_text_buffer_get_iter_at_*() function. A boolean is returned to know if @iter has been set to the exact location. Unit tests are added. https://bugzilla.gnome.org/show_bug.cgi?id=735341 gtk/gtktextbuffer.c | 95 ++++++++++++++++++++++++++-------- gtk/gtktextbuffer.h | 34 ++++++------- testsuite/gtk/textbuffer.c | 123 +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 215 insertions(+), 37 deletions(-) commit 2a95ab1828c8348910b10c82ec34018af841a066 Author: Matthias Clasen Date: Thu Oct 15 22:35:38 2015 -0400 Improve text a11y test Test appending text as well as replacing the entire text. Insert non-ASCII text to verify offsets are correct. testsuite/a11y/text.c | 78 +++++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 66 insertions(+), 12 deletions(-) commit 13f680d11a8b69bb11845864ed91cbd95b6b4214 Author: Matthias Clasen Date: Thu Oct 15 20:53:43 2015 -0400 file chooser: Avoid search interruption When the search entry is shown, the 'special' nature of ., ~ and / should not trigger the location entry, because that interrupts the search and is likely not what the user intended. https://bugzilla.gnome.org/show_bug.cgi?id=756505 gtk/gtkfilechooserwidget.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) commit b94ef83239acdc1967e72d027aef150d37466659 Author: Matthias Clasen Date: Thu Oct 29 19:21:47 2015 -0400 Assistant: Fix page rmoval We have to remove the page itself from the intermediate box first, before removing the box from the notebook. Otherwise, reffing the page to keep it alive is ineffective: the box gets destroyed, and that destruction recurses over the page. This fixes the problem in https://bugzilla.gnome.org/show_bug.cgi?id=756385 gtk/gtkassistant.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 4b7611bd93ee9a3df7bb01e5e9d5df2faace2455 Author: Cosimo Cecchi Date: Mon Nov 2 16:05:07 2015 -0800 menushell: don't call gtk_render_background() GtkMenu and GtkMenuBar, the two implementations of GtkMenuShell in GTK, already draw it. Furthermore, rendering a background here will overdraw any rendering that the subclass will do, such as arrows for scrolling menus. gtk/gtkmenushell.c | 15 --------------- 1 file changed, 15 deletions(-) commit 879630b83292ad13c558f3f2a374e30ac3e85919 Author: Matthias Clasen Date: Thu Oct 15 20:16:54 2015 -0400 entry completion: Only grab the device if we have one When the entry completion is popped up from a timeout, we may not have a device. In that case, don't call gdk_device_grab, do avoid criticals. gtk/gtkentrycompletion.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) commit 4cdec89bc47b9de4d102ccc1f4beba1d7ecc5203 Author: John Ralls Date: Fri Sep 18 15:12:24 2015 -0700 Bug 753992 - im-quartz discard_preedit segmentation fault Replace checking if the NSView is really a GdkWindow, which will crash in the likely event it's not a GObject, with ensuring that the parent GdkWindow is really a GdkWindowQuartz. (cherry picked from commit 571704824f78de9d8b262793397a4e4ea6cedf7d) modules/input/imquartz.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) commit 05a46f629dbc24dae6d5db3b491a009b653ed9c5 Author: Paolo Borelli Date: Thu Oct 29 17:20:54 2015 +0100 win32: handle WM_DISPLAYCHANGE globally Instead of handling WM_DISPLAYCHANGE on every GdkWindow, only handle it on an ad-hoc hidden window we create when opening the display. This has two reasons: 1) we want emit the display::size-changed signal even if there are no gtk windows currently open 2) we want to emit the signal just once and not once for every window https://bugzilla.gnome.org/show_bug.cgi?id=757324 gdk/win32/gdkdisplay-win32.c | 84 ++++++++++++++++++++++++++++++++++++++++++-- gdk/win32/gdkdisplay-win32.h | 2 ++ gdk/win32/gdkevents-win32.c | 12 ------- 3 files changed, 84 insertions(+), 14 deletions(-) commit 9a0d2366092a35594f07c50b483c697864066bdd Author: Georges Basile Stavracas Neto Date: Thu Oct 29 10:14:57 2015 -0200 placesview: vertically align path labels The current situation is somewhat sad, with the path label totally misaligned throughout the rows. This is fixed by using a size group for the path labels, so they all have the same allocated size (with the max of 15 chars). Also, instead of hiding the eject button, set it child-invisible, so it is hidden and yet it's size is allocated by GtkBox. https://bugzilla.gnome.org/show_bug.cgi?id=757303 gtk/gtkplacesview.c | 6 ++++++ gtk/gtkplacesviewrow.c | 18 +++++++++++++++++- gtk/gtkplacesviewrowprivate.h | 4 ++++ gtk/ui/gtkplacesviewrow.ui | 4 ++-- 4 files changed, 29 insertions(+), 3 deletions(-) commit dae857a94d66839d1623e017e890345f2d81c06e Author: Dominique Leuenberger Date: Thu Oct 29 13:56:18 2015 +0100 placessidebar: do not crash if uris is NULL On Drag'n'Drop actions across system boundaries (VM host to guest), the happen to be null. https://bugzilla.gnome.org/show_bug.cgi?id=757298 gtk/gtkplacessidebar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 680295587cf852e40d78389c3a068230edbdadb2 Author: Lars Uebernickel Date: Tue Oct 27 13:38:14 2015 +0100 gdkpixbuf-drawable: reinstate accidentally removed line gdk/gdkpixbuf-drawable.c | 1 + 1 file changed, 1 insertion(+) commit a950b5357ab8541212012f44f53caf236ce5aab9 Author: Lars Uebernickel Date: Mon Oct 26 10:12:34 2015 +0100 gdk_pixbuf_get_from_window: honor device scale gdk_pixbuf_get_from_window() paints the given window onto a new cairo surface. Create that new surface with the same device scale as the window so that the result is not scaled down on hidpi screens. https://bugzilla.gnome.org/show_bug.cgi?id=757147 gdk/gdkpixbuf-drawable.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) commit d8597e3177a6241311c386b90beecab0e55fbda5 Author: Marek Černocký Date: Tue Oct 27 07:37:14 2015 +0100 Added branch name po-properties/cs.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 06c70797580e95891d33981b768eaef25d772ff7 Author: Marek Černocký Date: Tue Oct 27 07:21:23 2015 +0100 Updated Czech translation po-properties/cs.po | 40 ++++++++++------------------------------ 1 file changed, 10 insertions(+), 30 deletions(-) commit 0a3f686cef35a2e94afaeaf2b5b72769fdc6f13b Author: Marek Černocký Date: Mon Oct 26 07:55:33 2015 +0100 Updated Czech translation po-properties/cs.po | 2790 ++++++++++++++++++++++++++------------------------- 1 file changed, 1426 insertions(+), 1364 deletions(-) commit fb8c947091b2e3ff204dc97cc74714518837ee9e Author: Chun-wei Fan Date: Fri Oct 23 10:21:25 2015 +0800 MSVC builds: Ensure /LTCG when necessary gtk3-demo, gtk3-demo-application and gtk3-icon-factory are built using /opt:noref as they use GResources without --manual-register, meaning that flag is used to avoid the linker from optimizing out the GResource items for release builds. Visual Studio 2015 changed its default link-time code generation setting to /LTCG:incremental, which would cause problems as it will cause the linker to optimize out the GResource items from the compiled code, so fix this by enforcing /LTCG for these three items. build/win32/vs10/gtk3-demo-application.vcxprojin | 2 ++ build/win32/vs10/gtk3-demo.vcxprojin | 30 +++++++++++++----------- build/win32/vs10/gtk3-icon-browser.vcxprojin | 2 ++ 3 files changed, 20 insertions(+), 14 deletions(-) commit 390c1119edaed1443a86e560991284eb13aeb4b9 Author: Owen W. Taylor Date: Tue Oct 20 16:45:52 2015 -0400 testgtk/Alpha Window: fix the drawn area when we are drawing decorations A GtkWindow's allocation includes the titlebar, borders, and shadows; we only want to draw our custom alpha content over the child allocation of the GtkWindow. https://bugzilla.gnome.org/show_bug.cgi?id=756886 tests/testgtk.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) commit e29b91139627ad167630dd6bff906f031d5fb05e Author: Owen W. Taylor Date: Tue Oct 20 16:43:06 2015 -0400 GtkWindow: draw the frame and shadow even for app-paintable windows If a window is decorated, we need to draw the frame and shadow, even if it is app-paintable - it's just nonsense to have a frame that we handle events on, but expect the app to paint it. (We paint the titlebar in any case.) If a client wants to handle all painting, it should use an undecorated window. https://bugzilla.gnome.org/show_bug.cgi?id=756886 gtk/gtkwindow.c | 38 ++++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) commit 132b776e1f63225de9fc6c1eb74aa08f04cf4bf7 Author: Owen W. Taylor Date: Tue Oct 20 12:39:57 2015 -0400 Guard against selection requestor disappearing We made a number of unchecked accesses to the selection requestor, which could cause X errors if the selection requestor vanished (or we were sent invalid events). Add error traps around all of them. See https://bugzilla.redhat.com/show_bug.cgi?id=1210814 for an example of a crash that could be caused by this. (There are about 1000 instances of such a crash in http://retrace.fedoraproject.org though no linked bug reports specifically talk about cut-and-paste or DND.) https://bugzilla.gnome.org/show_bug.cgi?id=756881 gtk/gtkselection.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit 7f42eee2505a03c8220d233067480623b5f26cd3 Author: Sveinn í Felli Date: Tue Oct 20 13:58:38 2015 +0000 Updated Icelandic translation po/is.po | 1589 +++++++++++++++++++++++++++++++++++++++----------------------- 1 file changed, 1008 insertions(+), 581 deletions(-) commit 57e592629b35a5b064e3815904d1ee9f96d93bbf Author: Inaki Larranaga Murgoitio Date: Tue Oct 20 10:47:00 2015 +0200 Updated Basque language po-properties/eu.po | 4618 +++++++++++++++++++++++++++------------------------ 1 file changed, 2415 insertions(+), 2203 deletions(-) commit d23fccd4a21ebb86f69c3ea8b0a852c278132b2a Author: Inaki Larranaga Murgoitio Date: Tue Oct 20 10:45:39 2015 +0200 Updated Basque language po/eu.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 6b6fbc73dec605168bb1eacc9ecc295aa4755002 Author: Inaki Larranaga Murgoitio Date: Tue Oct 20 10:39:47 2015 +0200 Updated Basque language po/eu.po | 4253 ++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 2213 insertions(+), 2040 deletions(-) commit 3c54eb4c6e5f5142f3579b468ec7ab29d5f8df84 Author: Matthias Clasen Date: Sat Oct 17 12:45:25 2015 -0400 Clean up handling of _gdk_win32_grab_cursor This is a variable holding a ref to an object, so it is a great case to use g_set_object and g_clear_object. # Please enter the commit message for your changes. Lines starting gdk/win32/gdkdevice-virtual.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) commit 1f2069c55c0cbfcdfc64808cea54d4c6cd1fa57a Author: Руслан Ижбулатов Date: Sat Oct 17 07:59:37 2015 +0000 W32: Add missing reference taking in gdk_device_virtual_grab() https://bugzilla.gnome.org/show_bug.cgi?id=756160 gdk/win32/gdkdevice-virtual.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1435d8c14883f4fcb834e09da22f31696d812ffd Author: Kjartan Maraas Date: Sat Oct 17 12:33:07 2015 +0200 Updated Norwegian bokmål translation. po/nb.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit bb40d64cb4224867ed1a27b1f59b3c97873b4bb0 Author: Kjartan Maraas Date: Sat Oct 17 12:32:18 2015 +0200 Updated Norwegian bokmål translation. po/nb.po | 75 +++++++++++++++++++++++++++------------------------------------- 1 file changed, 31 insertions(+), 44 deletions(-) commit 929c5ae2f36f2e69b7dadac5000e67d90b5bc72f Author: Dušan Kazik Date: Fri Oct 16 06:21:05 2015 +0000 Updated Slovak translation po-properties/sk.po | 2286 +++++++++++++++++++-------------------------------- 1 file changed, 852 insertions(+), 1434 deletions(-) commit db4837c607913916ca1bfed950991a79b3a46fa0 Author: Dušan Kazik Date: Fri Oct 16 06:18:01 2015 +0000 Updated Slovak translation po/sk.po | 1224 ++++++++++++++++++++++++++++++++++---------------------------- 1 file changed, 667 insertions(+), 557 deletions(-) commit 4c675d08a86f5c723e3b9bb431949ad14bf55fce Author: Matthias Clasen Date: Thu Oct 15 16:06:15 2015 -0400 scrolled window: Protect against nameless devices It seems that gdk_device_get_name() can return NULL. We should not crash if that happens. https://bugzilla.gnome.org/show_bug.cgi?id=756625 gtk/gtkscrolledwindow.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit c1ae56dfa8da461612a87e223729d4675bc304a0 Author: Carlos Garnacho Date: Wed Oct 14 17:27:53 2015 +0200 texthandle: Ensure handles are invalidated on mode changes Otherwise the "cursor" handle stays with "cursor" appearance instead of "selection end" when a text selection is started. gtk/gtktexthandle.c | 5 +++++ 1 file changed, 5 insertions(+) commit e67abe8758aa67fe5ff8c342da3090e413485278 Author: Carlos Garnacho Date: Wed Oct 14 17:41:12 2015 +0200 texthandle: small refactor These long enums are used too often, shorten things a bit with temp vars. gtk/gtktexthandle.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) commit ddeab4dfda871a5548e3d0c45c58c9ba0da9b72a Author: Carlos Garnacho Date: Wed Oct 14 17:21:25 2015 +0200 texthandle: Fix Y positioning of text handles It is assumed that border.top is the same than pointing_to.height (which equals the strong cursor position), which is not since some time ago. The border calculation has been move on top too, it is now used in the Y position one, and doesn't depend on anything we calculate later. gtk/gtktexthandle.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) commit c5631dfc9c3067d69ee210cc78034a7f624e9169 Author: Carlos Garnacho Date: Wed Oct 14 15:53:51 2015 +0200 texthandle: Fix handle dragging on wayland Text handles are subsurfaces on wayland, so sort of their own toplevel. This made gtk_widget_translate_coordinates() to bail out there, resulting in text handles being mispositioned and jumpy. To fix this, translate to toplevel GtkWindow coordinates manually, and translate coordinates from there. Along the way, the coordinates reported in ::handle-dragged have been fixed so there is no small jumps in either axis (most noticeable in the X axis when you started dragging, and in the Y axis when moving between lines of different heights. gtk/gtktexthandle.c | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) commit 396215615bc22fa97eb643aec1fcbbb801f4d300 Author: Jonas Ådahl Date: Tue Oct 13 20:53:39 2015 +0800 GtkWindow: Enlarge the type hint private field Make it what it is - the enum - so that that it is sure that the hint will fit in the field. Without this, any hint that doesn't fit in 3 bits will be truncated to the 3 least significant bits, causing unexpected behaviour. https://bugzilla.gnome.org/show_bug.cgi?id=756496 gtk/gtkwindow.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) commit 577fb25b008d0198b971d28ada4a57b3fb80042f Author: Carlos Soriano Date: Thu Sep 24 11:54:58 2015 +0200 gtkplacesview: align spinner with header label Use the box margin top instead of the label margin top, so the spinner remains aligned with the header label. https://bugzilla.gnome.org/show_bug.cgi?id=756568 gtk/gtkplacesview.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3f7095c36e7a9733aa1167085dc35db02ced3463 Author: Carlos Soriano Date: Wed Oct 14 22:04:35 2015 +0200 gtkplacesview: plug leak https://bugzilla.gnome.org/show_bug.cgi?id=756568 gtk/gtkplacesview.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 50737f4e6b2b75d20dc8f300b4d4b8f6b7d3046d Author: Carlos Soriano Date: Thu Sep 24 14:49:30 2015 +0200 gtkplacesview: remove hover color from rows Since other views are not using hover neither https://bugzilla.gnome.org/show_bug.cgi?id=756568 gtk/theme/Adwaita/_common.scss | 4 ++++ gtk/theme/Adwaita/gtk-contained-dark.css | 2 ++ gtk/theme/Adwaita/gtk-contained.css | 2 ++ 3 files changed, 8 insertions(+) commit 343fafbc3018a8d2388322436289d17f57a3e094 Author: Carlos Soriano Date: Thu Sep 24 11:26:59 2015 +0200 gtkplacesview: add a clear button to address entry So it allows a quick way to clear the entry. https://bugzilla.gnome.org/show_bug.cgi?id=756568 gtk/gtkplacesview.c | 22 ++++++++++++++++++++-- gtk/ui/gtkplacesview.ui | 1 + 2 files changed, 21 insertions(+), 2 deletions(-) commit 8bb36ed031b407a8183cca746754af46dc8a00fd Author: Carlos Soriano Date: Thu Sep 24 11:04:39 2015 +0200 gtkplacesview: rotate server list icon on toggled Disclosure triangles are usually used pointing down, however in this case the popover spawns in the upper direction, which makes it odd looking. Instead of pointing always down or up, point down when not toggled and animate a rotation when toggled. https://bugzilla.gnome.org/show_bug.cgi?id=756568 gtk/theme/Adwaita/_common.scss | 16 ++++++++++++++++ gtk/theme/Adwaita/gtk-contained-dark.css | 10 ++++++++++ gtk/theme/Adwaita/gtk-contained.css | 10 ++++++++++ gtk/ui/gtkplacesview.ui | 5 ++++- 4 files changed, 40 insertions(+), 1 deletion(-) commit 0b773e6704629485404e00d13aa4efe7071184ea Author: Carlos Soriano Date: Wed Sep 23 19:55:11 2015 +0200 gtkplacesview: tweak ui to allow more server rows Following design guidance, reduce row height and increase popover height so the user is allowed to see more than 3 rows. https://bugzilla.gnome.org/show_bug.cgi?id=756568 gtk/gtkplacesview.c | 2 +- gtk/ui/gtkplacesview.ui | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit e1afa087af02eb14003597f222c3debcbf09fc39 Author: Carlos Soriano Date: Wed Oct 14 21:48:06 2015 +0200 gtkplacesview: improve heuristics for external drives Following the sidebar on commit b0989b190df, improve the way we check when a drive is external or not. https://bugzilla.gnome.org/show_bug.cgi?id=756589 gtk/gtkplacesview.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) commit 4c833b21c8306c312e0bd71baf56a8f5e4771915 Author: Carlos Soriano Date: Wed Oct 14 21:47:39 2015 +0200 gtkplacesview: remove dead code This is checked on add_volume inside the loop. https://bugzilla.gnome.org/show_bug.cgi?id=756589 gtk/gtkplacesview.c | 4 ---- 1 file changed, 4 deletions(-) commit df687b59305889f1827b396fb07e459213504d7f Author: Carlos Soriano Date: Wed Oct 14 21:47:03 2015 +0200 gtkplacesview: remove dead code This is checked on is_removable_volume https://bugzilla.gnome.org/show_bug.cgi?id=756589 gtk/gtkplacesview.c | 15 --------------- 1 file changed, 15 deletions(-) commit 40f5a35a69b9d1ffd0c29428d8bf6218d9a822ad Author: Ross Lagerwall Date: Sun Sep 27 15:59:49 2015 +0100 gtkplacessidebar: Show drives with removable media Some drives have removable media that is not ejectable (e.g. a laptop's SD card reader). Show volumes on these drives in the sidebar. https://bugzilla.gnome.org/show_bug.cgi?id=755654 gtk/gtkplacessidebar.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 9356cb8ea155e7438e372c2da7bb3b0c067677dc Author: Marek Černocký Date: Tue Oct 13 12:02:29 2015 +0200 Updated Czech translation po/cs.po | 491 +++++++++++++++++++++++++++------------------------------------ 1 file changed, 213 insertions(+), 278 deletions(-) commit c344d6dc175bb95654fda19dbc4f31f4256b6f70 Author: Carlos Garnacho Date: Tue Oct 13 00:24:18 2015 +0200 textview: Ensure magnifier popover points within widget area Otherwise the popopver will be automatically unmapped in _gtk_popover_update_child_visible() when the X axis (coming more or less directly from events) goes outside the textview. gtk/gtktextview.c | 4 ++++ 1 file changed, 4 insertions(+) commit 0a97d052585cf887296adf5d8fd2f1b0de7427a2 Author: Carlos Garnacho Date: Tue Oct 13 00:21:43 2015 +0200 popover: Invalidate borders on tail position changes There's nothing doing this explicitly, so tail position changes may leave trails of older positions. https://bugzilla.gnome.org/show_bug.cgi?id=756449 gtk/gtkpopover.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) commit 17ea79f33a1498f493da1246149429a8388a65bf Author: Carlos Garnacho Date: Fri Oct 9 16:14:31 2015 +0200 wayland: Set a more believable crossing detail on pointer enter/leave GDK_NOTIFY_ANCESTOR would happen when the pointer crosses across a direct parent/child. However nonlinear events are more likely, specially when the pointer moves across toplevels (either different apps, or menus being popped up over the pointer position). This makes popping up comboboxes and other menus that fall over the pointer position possible. With the previous detail the GtkMenu code misinterpreted the crossing event, making it think the button release coming right after should dismiss the popup, which made menus just flash on the screen unless you kept the button pressed. gdk/wayland/gdkdevice-wayland.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)